Issue 26592003: Switch CdmWrapper to use uint32_t for size types per style guide.

Issue 26592003: Switch CdmWrapper to use uint32_t for size types per style guide. (Closed)

Created:
7 years, 2 months ago by DaleCurtis

Modified:
7 years, 2 months ago

Reviewers:
xhwang, ddorwin

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Switch CdmWrapper to use uint32_t for size types per style guide. BUG=none TEST=compiles Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230385

Patch Set 3 : Stub out deferred impl. #

Total comments: 4

Patch Set 4 : Rebase over audio. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -87 lines)			Patch
M	DEPS	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	media/cdm/ppapi/cdm_adapter.h	View	1 2	2 chunks	+10 lines, -7 lines	0 comments	Download
M	media/cdm/ppapi/cdm_adapter.cc	View	1 2 3	10 chunks	+22 lines, -20 lines	0 comments	Download
M	media/cdm/ppapi/cdm_helpers.h	View	1	7 chunks	+18 lines, -20 lines	0 comments	Download
M	media/cdm/ppapi/cdm_helpers.cc	View	1	3 chunks	+7 lines, -7 lines	0 comments	Download
M	media/cdm/ppapi/cdm_wrapper.h	View	1 2 3	4 chunks	+15 lines, -15 lines	0 comments	Download
M	media/cdm/ppapi/clear_key_cdm.h	View	1 2 3	1 chunk	+9 lines, -6 lines	0 comments	Download
M	media/cdm/ppapi/clear_key_cdm.cc	View	1 2 3	7 chunks	+13 lines, -11 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

ddorwin

LG. Will wait to see what issues we might encounter. https://codereview.chromium.org/26592003/diff/1/media/cdm/ppapi/clear_key_cdm.cc File media/cdm/ppapi/clear_key_cdm.cc (right): https://codereview.chromium.org/26592003/diff/1/media/cdm/ppapi/clear_key_cdm.cc#newcode519 ...

7 years, 2 months ago (2013-10-08 23:53:20 UTC) #1

xhwang

lgtm % comments https://codereview.chromium.org/26592003/diff/34001/media/cdm/ppapi/clear_key_cdm.cc File media/cdm/ppapi/clear_key_cdm.cc (right): https://codereview.chromium.org/26592003/diff/34001/media/cdm/ppapi/clear_key_cdm.cc#newcode142 media/cdm/ppapi/clear_key_cdm.cc:142: cdm::Host* host = static_cast<cdm::Host*>( Use cdm::ContentDecryptionModule_1::Host ...

7 years, 2 months ago (2013-10-22 20:43:03 UTC) #4

DaleCurtis

Required rebasing over https://codereview.chromium.org/26956002/ to make that change -- which is about to land. I'll ...

7 years, 2 months ago (2013-10-22 21:03:09 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/26592003/104001

7 years, 2 months ago (2013-10-23 05:44:20 UTC) #6

Message was sent while issue was closed.

Change committed as 230385

Expand Messages | Collapse Messages