Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2659123003: Remove compiler field from iOS bot configs, ensure gn_args match configuration (Closed)

Created:
3 years, 10 months ago by smut
Modified:
3 years, 10 months ago
Reviewers:
Dirk Pranke, dpranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove compiler field from iOS bot configs, ensure gn_args match configuration The configuration field will be removed next, so we need to ensure the is_debug gn_arg is set everywhere. BUG=686304 Review-Url: https://codereview.chromium.org/2659123003 Cr-Commit-Position: refs/heads/master@{#447089} Committed: https://chromium.googlesource.com/chromium/src/+/616850176d43488073a0b757f4330264c873dbc3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -43 lines) Patch
M ios/build/bots/chromium.fyi/ClangToTiOS.json View 3 chunks +1 line, -4 lines 0 comments Download
M ios/build/bots/chromium.fyi/EarlGreyiOS.json View 2 chunks +1 line, -4 lines 0 comments Download
M ios/build/bots/chromium.fyi/GomaCanaryiOS.json View 3 chunks +1 line, -4 lines 0 comments Download
M ios/build/bots/chromium.fyi/ios-simulator.json View 2 chunks +0 lines, -4 lines 0 comments Download
M ios/build/bots/chromium.fyi/ios-simulator-cronet.json View 1 chunk +1 line, -1 line 0 comments Download
M ios/build/bots/chromium.mac/ios-device.json View 3 chunks +1 line, -6 lines 0 comments Download
M ios/build/bots/chromium.mac/ios-device-xcode-clang.json View 3 chunks +1 line, -6 lines 0 comments Download
M ios/build/bots/chromium.mac/ios-simulator.json View 2 chunks +0 lines, -5 lines 0 comments Download
M ios/build/bots/chromium.mac/ios-simulator-cronet.json View 2 chunks +1 line, -4 lines 0 comments Download
M ios/build/bots/chromium.mac/ios-simulator-xcode-clang.json View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
smut
3 years, 10 months ago (2017-01-28 00:57:53 UTC) #2
Dirk Pranke
lgtm
3 years, 10 months ago (2017-01-28 23:20:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659123003/1
3 years, 10 months ago (2017-01-30 21:22:33 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 22:22:06 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/616850176d43488073a0b757f433...

Powered by Google App Engine
This is Rietveld 408576698