src/runtime/runtime-futex.cc - Issue 2659083004: [SAB] Fix crash in Atomics.wake w/ infinite count.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-futex.cc

Issue 2659083004: [SAB] Fix crash in Atomics.wake w/ infinite count. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-futex.cc

diff --git a/src/runtime/runtime-futex.cc b/src/runtime/runtime-futex.cc

index 35282598ffa4100f963271c86f83435d4031c00e..dae972c72dcfbbb347c40d6e54ebd6889a7f1194 100644

--- a/src/runtime/runtime-futex.cc

+++ b/src/runtime/runtime-futex.cc

@@ -45,7 +45,7 @@ RUNTIME_FUNCTION(Runtime_AtomicsWake) {

DCHECK_EQ(3, args.length());

CONVERT_ARG_HANDLE_CHECKED(JSTypedArray, sta, 0);

CONVERT_SIZE_ARG_CHECKED(index, 1);

- CONVERT_INT32_ARG_CHECKED(count, 2);

+ CONVERT_DOUBLE_ARG_CHECKED(count, 2);

CHECK(sta->GetBuffer()->is_shared());

CHECK_LT(index, NumberToSize(sta->length()));

CHECK_EQ(sta->type(), kExternalInt32Array);