Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: src/futex-emulation.h

Issue 2659083004: [SAB] Fix crash in Atomics.wake w/ infinite count. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/futex-emulation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/futex-emulation.h
diff --git a/src/futex-emulation.h b/src/futex-emulation.h
index f1f3655dc74f49f26331840e4fffeeb971ee289d..3a720c3a0bc5161b7178dfd527d3c6c54748b493 100644
--- a/src/futex-emulation.h
+++ b/src/futex-emulation.h
@@ -92,10 +92,11 @@ class FutexEmulation : public AllStatic {
size_t addr, int32_t value, double rel_timeout_ms);
// Wake |num_waiters_to_wake| threads that are waiting on the given |addr|.
- // The rest of the waiters will continue to wait. The return value is the
- // number of woken waiters.
+ // |num_waiters_to_wake| can be +infinity, in which case all waiters are
+ // woken. The rest of the waiters will continue to wait. The return value is
+ // the number of woken waiters.
static Object* Wake(Isolate* isolate, Handle<JSArrayBuffer> array_buffer,
- size_t addr, int num_waiters_to_wake);
+ size_t addr, double num_waiters_to_wake);
Camillo Bruni 2017/01/30 19:09:17 Why not use -1 (or a separate flag and convert -1
binji 2017/01/31 22:36:06 Done.
// Return the number of threads waiting on |addr|. Should only be used for
// testing.
« no previous file with comments | « no previous file | src/futex-emulation.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698