[SAB] Fix crash in Atomics.wake w/ infinite count.

[SAB] Fix crash in Atomics.wake w/ infinite count.

Also if the count is not specified, it should wake all waiters.

BUG=v8:4777
Review-Url: https://codereview.chromium.org/2659083004
Cr-Commit-Position: refs/heads/master@{#42871}
Committed: https://chromium.googlesource.com/v8/v8/+/aa3422b6713040ace576f776b9373765e4e9806c

[binji, 2017-01-27 20:28:27]

binji@chromium.org changed reviewers:
+ cbruni@chromium.org

[binji, 2017-01-27 20:28:38]

The CQ bit was checked by binji@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 20:28:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 21:06:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 21:06:49]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2017-01-30 19:09:18]

https://codereview.chromium.org/2659083004/diff/1/src/futex-emulation.h
File src/futex-emulation.h (right):

https://codereview.chromium.org/2659083004/diff/1/src/futex-emulation.h#newco...
src/futex-emulation.h:99: size_t addr, double num_waiters_to_wake);
Why not use -1 (or a separate flag and convert -1 in the RuntimeFunction to the
flag)? Doubles are inherently expensive.

[binji, 2017-01-31 22:36:07]

https://codereview.chromium.org/2659083004/diff/1/src/futex-emulation.h
File src/futex-emulation.h (right):

https://codereview.chromium.org/2659083004/diff/1/src/futex-emulation.h#newco...
src/futex-emulation.h:99: size_t addr, double num_waiters_to_wake);
On 2017/01/30 19:09:17, Camillo Bruni wrote:
> Why not use -1 (or a separate flag and convert -1 in the RuntimeFunction to
the
> flag)? Doubles are inherently expensive.

Done.

[binji, 2017-01-31 22:36:12]

The CQ bit was checked by binji@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 22:36:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 23:06:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 23:06:34]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2017-02-01 01:54:02]

lgtm

[binji, 2017-02-01 21:45:18]

The CQ bit was checked by binji@chromium.org

[commit-bot: I haz the power, 2017-02-01 21:45:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 21:47:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485985518184750,
"parent_rev": "6a82fe90684b16f885fe33bbf37e5c7f68dcbcf9", "commit_rev":
"aa3422b6713040ace576f776b9373765e4e9806c"}

[commit-bot: I haz the power, 2017-02-01 21:47:27]

Description was changed from

==========
[SAB] Fix crash in Atomics.wake w/ infinite count.

Also if the count is not specified, it should wake all waiters.

BUG=v8:4777
==========

to

==========
[SAB] Fix crash in Atomics.wake w/ infinite count.

Also if the count is not specified, it should wake all waiters.

BUG=v8:4777

Review-Url: https://codereview.chromium.org/2659083004
Cr-Commit-Position: refs/heads/master@{#42871}
Committed:
https://chromium.googlesource.com/v8/v8/+/aa3422b6713040ace576f776b9373765e4e...
==========

[commit-bot: I haz the power, 2017-02-01 21:47:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/aa3422b6713040ace576f776b9373765e4e...