Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 2659063003: Avoid non-opaque->opaque requests to SkCanvas::writePixels() (Closed)

Created:
3 years, 10 months ago by msarett
Modified:
3 years, 10 months ago
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, Stephen Chennney, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Rik, f(malita), blink-reviews, kinuko+watch, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid non-opaque->opaque requests to SkCanvas::writePixels() While we're working on defining this, let's update the callsite to avoid utilizing an undefined behavior. BUG=skia:6021 BUG=skia:6157 Review-Url: https://codereview.chromium.org/2659063003 Cr-Commit-Position: refs/heads/master@{#448309} Committed: https://chromium.googlesource.com/chromium/src/+/beb8b50583644cbb1e2d48d0d08db3a499712b05

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 1 chunk +14 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
msarett1
3 years, 10 months ago (2017-01-27 21:37:39 UTC) #3
msarett1
Ping :), any thoughts junov?
3 years, 10 months ago (2017-02-06 14:38:50 UTC) #7
Justin Novosad
lgtm
3 years, 10 months ago (2017-02-06 15:53:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659063003/1
3 years, 10 months ago (2017-02-06 15:54:57 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 18:16:33 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/beb8b50583644cbb1e2d48d0d08d...

Powered by Google App Engine
This is Rietveld 408576698