Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 2659053002: [parser] Skipping inner funcs: make basic variable declarations work. (Closed)

Created:
3 years, 10 months ago by marja
Modified:
3 years, 10 months ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com, adamk, Toon Verwaest, jochen (gone - plz use gerrit)
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Skipping inner funcs: make basic variable declarations work. BUG=v8:5516 Review-Url: https://codereview.chromium.org/2659053002 Cr-Commit-Position: refs/heads/master@{#42739} Committed: https://chromium.googlesource.com/v8/v8/+/2dac4588ee673a27f7a469d254a1cb0b5969d8f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M src/ast/scopes.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +22 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
marja
ptal
3 years, 10 months ago (2017-01-27 12:52:38 UTC) #4
vogelheim
lgtm
3 years, 10 months ago (2017-01-27 12:56:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659053002/1
3 years, 10 months ago (2017-01-27 13:02:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/2dac4588ee673a27f7a469d254a1cb0b5969d8f5
3 years, 10 months ago (2017-01-27 13:24:34 UTC) #11
marja
3 years, 10 months ago (2017-01-27 14:10:56 UTC) #12
Message was sent while issue was closed.
(adamk, verwaest, jochen, fyi, and earlier CL from today)

Powered by Google App Engine
This is Rietveld 408576698