Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2659033002: Worklet: Move WorkletScriptLoader from core/workers to core/loader (Closed)

Created:
3 years, 11 months ago by nhiroki
Modified:
3 years, 10 months ago
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worklet: Move WorkletScriptLoader from core/workers to core/loader This CL moves WorkletScriptLoader from core/workers to core/loader because clients of Resource classes should be placed under core/loader in terms of modularity. This is a simple moving patch and should not change behavior. BUG=627945 Review-Url: https://codereview.chromium.org/2659033002 Cr-Commit-Position: refs/heads/master@{#446784} Committed: https://chromium.googlesource.com/chromium/src/+/14ab9f9226faafb2c153f1d63b8bf8060d91260e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -147 lines) Patch
M third_party/WebKit/Source/core/loader/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/loader/WorkletScriptLoader.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/loader/WorkletScriptLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/Worklet.h View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/core/workers/WorkletScriptLoader.h View 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/WebKit/Source/core/workers/WorkletScriptLoader.cpp View 1 chunk +0 lines, -69 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
nhiroki
PTAL, thanks!
3 years, 11 months ago (2017-01-27 07:22:00 UTC) #5
Takashi Toyoshima
lgtm.
3 years, 11 months ago (2017-01-27 07:47:35 UTC) #6
kouhei (in TOK)
core lgtm
3 years, 10 months ago (2017-01-27 18:14:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659033002/1
3 years, 10 months ago (2017-01-27 18:14:50 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/222064)
3 years, 10 months ago (2017-01-27 20:22:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659033002/1
3 years, 10 months ago (2017-01-27 20:28:44 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 21:44:27 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/14ab9f9226faafb2c153f1d63b8b...

Powered by Google App Engine
This is Rietveld 408576698