Re-add WebString::equals that takes const char* only

Re-add WebString::equals that takes const char* only

I replaced this with the one that takes length, but it forced
other callsites that were manually calling equals() with literals
to call strlen().  This fixes it to readd the version that only
takes const char*.

BUG=667131
R=esprehn@chromium.org, csharrison@chromium.org

Review-Url: https://codereview.chromium.org/2659023002
Cr-Commit-Position: refs/heads/master@{#446651}
Committed: https://chromium.googlesource.com/chromium/src/+/1a681e3ecb0e8885fff42917be3c942fd05e0984

[kinuko, 2017-01-27 07:01:57]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 07:02:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2017-01-27 07:02:24]

PTL-- thanks!

[kinuko, 2017-01-27 07:29:39]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 07:29:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2017-01-27 09:28:21]

It occurs to me this is a behavior change where we make all char* strings be
latin1 or ASCII and not utf8. Seems reasonable but it is a change.

Lgtm

[kinuko, 2017-01-27 10:30:47]

On 2017/01/27 09:28:21, esprehn wrote:
> It occurs to me this is a behavior change where we make all char* strings be
> latin1 or ASCII and not utf8. Seems reasonable but it is a change.
> 
> Lgtm

Yeah that is true.  Thanks for clarifying, and I hope it makes sense.

[kinuko, 2017-01-27 10:51:10]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2017-01-27 10:51:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 12:38:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485514270709810,
"parent_rev": "9b69dd7f422f29571bfd72da3d452a3580f33d79", "commit_rev":
"1a681e3ecb0e8885fff42917be3c942fd05e0984"}

[commit-bot: I haz the power, 2017-01-27 12:39:20]

Description was changed from

==========
Re-add WebString::equals that takes const char* only

I replaced this with the one that takes length, but it forced
other callsites that were manually calling equals() with literals
to call strlen().  This fixes it to readd the version that only
takes const char*.

BUG=667131
R=esprehn@chromium.org, csharrison@chromium.org
==========

to

==========
Re-add WebString::equals that takes const char* only

I replaced this with the one that takes length, but it forced
other callsites that were manually calling equals() with literals
to call strlen().  This fixes it to readd the version that only
takes const char*.

BUG=667131
R=esprehn@chromium.org, csharrison@chromium.org

Review-Url: https://codereview.chromium.org/2659023002
Cr-Commit-Position: refs/heads/master@{#446651}
Committed:
https://chromium.googlesource.com/chromium/src/+/1a681e3ecb0e8885fff42917be3c...
==========

[commit-bot: I haz the power, 2017-01-27 12:39:22]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1a681e3ecb0e8885fff42917be3c...

[Charlie Harrison, 2017-01-27 13:23:57]

I am a bit confused how callers using str.equals("literal") were calling into
strlen with the old code. Wouldn't it instead construct an implicit
WebString("literal") and do the allocation?

[kinuko, 2017-01-27 15:39:48]

On 2017/01/27 13:23:57, Charlie Harrison wrote:
> I am a bit confused how callers using str.equals("literal") were calling into
> strlen with the old code. Wouldn't it instead construct an implicit
> WebString("literal") and do the allocation?

You're right, that's what was happening, I saw WebString was being constructed
but didn't correctly check which one.

[Charlie Harrison, 2017-01-27 15:42:31]

Great catch then! That is very undesirable, much worse than extra strlens.

lgtm