Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline_unittest.py

Issue 2658983003: Add build link to rebaseline-o-matic CL descriptions. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline_unittest.py
index 72ba0f54b727bdad95d4f132c94100932a34e6a1..98f9d71a5ce2325df3b57d8c2ac90fa584ffb382 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline_unittest.py
@@ -107,22 +107,26 @@ class TestAutoRebaseline(BaseTestCase):
commit = "abcd567"
bugs = set()
self.assertEqual(self.command.commit_message(author, revision, commit, bugs),
- """Auto-rebaseline for r1234
-
-https://chromium.googlesource.com/chromium/src/+/abcd567
-
-TBR=foo@chromium.org
-""")
+ 'Auto-rebaseline for r1234\n\n'
+ 'https://chromium.googlesource.com/chromium/src/+/abcd567\n\n'
+ 'TBR=foo@chromium.org\n')
bugs = set(["234", "345"])
self.assertEqual(self.command.commit_message(author, revision, commit, bugs),
- """Auto-rebaseline for r1234
-
-https://chromium.googlesource.com/chromium/src/+/abcd567
-
-BUG=234,345
-TBR=foo@chromium.org
-""")
+ 'Auto-rebaseline for r1234\n\n'
+ 'https://chromium.googlesource.com/chromium/src/+/abcd567\n\n'
+ 'BUG=234,345\n'
+ 'TBR=foo@chromium.org\n')
+
+ self.tool.environ['BUILDBOT_MASTERNAME'] = 'my.master'
+ self.tool.environ['BUILDBOT_BUILDERNAME'] = 'b'
+ self.tool.environ['BUILDBOT_BUILDNUMBER'] = '123'
+ self.assertEqual(self.command.commit_message(author, revision, commit, bugs),
+ 'Auto-rebaseline for r1234\n\n'
+ 'Build: https://build.chromium.org/p/my.master/builders/b/builds/123\n\n'
+ 'https://chromium.googlesource.com/chromium/src/+/abcd567\n\n'
+ 'BUG=234,345\n'
+ 'TBR=foo@chromium.org\n')
def test_no_needs_rebaseline_lines(self):
def blame(_):

Powered by Google App Engine
This is Rietveld 408576698