Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1611)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline.py

Issue 2658983003: Add build link to rebaseline-o-matic CL descriptions. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline.py
index 0e2f0e2e65d02d0b5b6a53cfabc72f536ce606f3..0e553dfbecd160c08eb6680c940ffeffc9992886 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline.py
@@ -17,7 +17,7 @@ import time
import traceback
import urllib2
-from webkitpy.common.net.buildbot import Build
+from webkitpy.common.net.buildbot import Build, current_build_link
from webkitpy.layout_tests.models.test_expectations import TestExpectations, BASELINE_SUFFIX_LIST
from webkitpy.tool.commands.rebaseline import AbstractParallelRebaselineCommand
@@ -135,21 +135,20 @@ class AutoRebaseline(AbstractParallelRebaselineCommand):
return tests, revision, commit, author, bugs, has_any_needs_rebaseline_lines
- @staticmethod
- def link_to_patch(commit):
- return "https://chromium.googlesource.com/chromium/src/+/" + commit
-
def commit_message(self, author, revision, commit, bugs):
- bug_string = ""
+ message = 'Auto-rebaseline for r%s\n\n' % revision
+ build_link = current_build_link(self._tool)
+ if build_link:
+ message += 'Build: %s\n\n' % build_link
+ message += '%s\n\n' % self.link_to_patch(commit)
if bugs:
- bug_string = "BUG=%s\n" % ",".join(bugs)
-
- return """Auto-rebaseline for r%s
+ message += 'BUG=%s\n' % ','.join(bugs)
+ message += 'TBR=%s\n' % author
+ return message
-%s
-
-%sTBR=%s
-""" % (revision, self.link_to_patch(commit), bug_string, author)
+ @staticmethod
+ def link_to_patch(commit):
+ return 'https://chromium.googlesource.com/chromium/src/+/' + commit
def get_test_prefix_list(self, tests):
test_prefix_list = {}

Powered by Google App Engine
This is Rietveld 408576698