Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2658963002: MD Settings: paper-toggle-button version 1.2.0 -> 1.3.0 (Closed)

Created:
3 years, 11 months ago by scottchen
Modified:
3 years, 10 months ago
Reviewers:
Dan Beam, michaelpg
CC:
chromium-reviews, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: paper-toggle-button version 1.2.0 -> 1.3.0 BUG=684152 Review-Url: https://codereview.chromium.org/2658963002 Cr-Commit-Position: refs/heads/master@{#446840} Committed: https://chromium.googlesource.com/chromium/src/+/c77aea94a85c3b57791290c63411d4c5b0b845fe

Patch Set 1 #

Total comments: 4

Patch Set 2 : check sed version in check_dep instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M third_party/polymer/v1_0/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toggle-button/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toggle-button/paper-toggle-button.html View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components_summary.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/reproduce.sh View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
scottchen
3 years, 11 months ago (2017-01-26 22:12:49 UTC) #2
scottchen
3 years, 11 months ago (2017-01-26 23:37:53 UTC) #4
michaelpg
https://codereview.chromium.org/2658963002/diff/1/third_party/polymer/v1_0/reproduce.sh File third_party/polymer/v1_0/reproduce.sh (right): https://codereview.chromium.org/2658963002/diff/1/third_party/polymer/v1_0/reproduce.sh#newcode12 third_party/polymer/v1_0/reproduce.sh:12: # Mac users - first install GNU-sed over the ...
3 years, 11 months ago (2017-01-27 03:07:12 UTC) #9
scottchen
https://codereview.chromium.org/2658963002/diff/1/third_party/polymer/v1_0/reproduce.sh File third_party/polymer/v1_0/reproduce.sh (right): https://codereview.chromium.org/2658963002/diff/1/third_party/polymer/v1_0/reproduce.sh#newcode12 third_party/polymer/v1_0/reproduce.sh:12: # Mac users - first install GNU-sed over the ...
3 years, 10 months ago (2017-01-27 19:48:39 UTC) #11
Dan Beam
lgtm
3 years, 10 months ago (2017-01-27 20:30:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658963002/20001
3 years, 10 months ago (2017-01-27 21:50:14 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-01-28 00:00:45 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c77aea94a85c3b57791290c63411...

Powered by Google App Engine
This is Rietveld 408576698