Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2658923002: [SystemWebViewLayoutTest] Update expectations and re-enable testWebViewExcludedInterfaces. (Closed)

Created:
3 years, 11 months ago by timvolodine
Modified:
3 years, 10 months ago
Reviewers:
Tobias Sargeant
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SystemWebViewLayoutTest] Update expectations and re-enable testWebViewExcludedInterfaces. Update non-exposed interfaces and re-enable broken test, due to https://codereview.chromium.org/2642873002 non exposed attributes: attribute mojo -> attribute gin BUG=683153 TBR=tobiasjs@chromium.org Review-Url: https://codereview.chromium.org/2658923002 Cr-Commit-Position: refs/heads/master@{#446683} Committed: https://chromium.googlesource.com/chromium/src/+/d3688ba478b1992affc20ec3209efe7fef9577be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTest.java View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658923002/1
3 years, 10 months ago (2017-01-27 16:24:44 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 16:35:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d3688ba478b1992affc20ec3209e...

Powered by Google App Engine
This is Rietveld 408576698