Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2658903002: Implement detaching the TabModelSelector from the CompositorViewHolder (Closed)

Created:
3 years, 11 months ago by mthiesse
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Implement detaching the TabModelSelector from the CompositorViewHolder Essentially returns the CompositorViewHolder to a state where the TabModelSelector hasn't been set, and allows the TabModelSelector to be re-attached. This allows VR Shell to control the size of CVCs, as the CompositorViewHolder no longer owns the CVC while in VR. BUG=680240 Review-Url: https://codereview.chromium.org/2641043002 Cr-Commit-Position: refs/heads/master@{#445419} (cherry picked from commit 19d9d40d78985410d311f7937186943928580fb1) Review-Url: https://codereview.chromium.org/2658903002 . Cr-Commit-Position: refs/branch-heads/2987@{#118} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/9341b1c39c879f65c46421c7876c310d590a8de0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -32 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java View 10 chunks +52 lines, -18 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerHost.java View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapper.java View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapperImpl.java View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java View 5 chunks +9 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/compositor/layouts/MockLayoutHost.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java View 2 chunks +70 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mthiesse
3 years, 11 months ago (2017-01-26 20:56:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9341b1c39c879f65c46421c7876c310d590a8de0.

Powered by Google App Engine
This is Rietveld 408576698