Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 26589002: Merge 227148 "Mac: Do not ask to handle power events in processe..." (Closed)

Created:
7 years, 2 months ago by tapted
Modified:
7 years, 2 months ago
Reviewers:
tapted
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Merge 227148 "Mac: Do not ask to handle power events in processe..." > Mac: Do not ask to handle power events in processes with no PowerManager. > > Otherwise Chrome causes a 30-second delay trying to put a Mac to sleep. > > Only the main browser process, and nacl processes, create a > PowerMonitorDeviceSource. However, renderers and other processes still > call the static function PowerMonitorDeviceSource::AllocateSystemIOPorts. > This results in the process asking to receive power change > notifications, but not hooking up a function to acknowledge them. This > results in 30-second timeouts while trying to sleep a Mac. > > This change removes plugin, renderer, utility and worker processes from > the list of process types that register to receive power change events > from OS X. > > BUG=132336 > TEST=Put a Mac to sleep with Chrome running. After waking, run `pmset -g > log` from Terminal. There should be no new entries for Chrome under > applicationresponse.timedout [10.6] or on a `Timedout` line [10.8] > > Review URL: https://codereview.chromium.org/25954005 TBR=tapted@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227608

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/app/content_main_runner.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tapted
7 years, 2 months ago (2013-10-08 22:06:05 UTC) #1
tapted
7 years, 2 months ago (2013-10-08 22:07:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r227608.

Powered by Google App Engine
This is Rietveld 408576698