Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 25954005: Mac: Do not ask to handle power events in processes with no PowerManager. (Closed)

Created:
7 years, 2 months ago by tapted
Modified:
7 years, 2 months ago
Reviewers:
agl, bajones
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, chrome-apps-syd-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Mac: Do not ask to handle power events in processes with no PowerManager. Otherwise Chrome causes a 30-second delay trying to put a Mac to sleep. Only the main browser process, and nacl processes, create a PowerMonitorDeviceSource. However, renderers and other processes still call the static function PowerMonitorDeviceSource::AllocateSystemIOPorts. This results in the process asking to receive power change notifications, but not hooking up a function to acknowledge them. This results in 30-second timeouts while trying to sleep a Mac. This change removes plugin, renderer, utility and worker processes from the list of process types that register to receive power change events from OS X. BUG=132336 TEST=Put a Mac to sleep with Chrome running. After waking, run `pmset -g log` from Terminal. There should be no new entries for Chrome under applicationresponse.timedout [10.6] or on a `Timedout` line [10.8] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227148

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/app/content_main_runner.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tapted
Hi Adam, Brandon - please take a look. But feel free to take the bug ...
7 years, 2 months ago (2013-10-04 07:31:47 UTC) #1
agl
LGTM for OWNERS iff bajones is happy with it.
7 years, 2 months ago (2013-10-04 14:39:34 UTC) #2
bajones
On 2013/10/04 14:39:34, agl wrote: > LGTM for OWNERS iff bajones is happy with it. ...
7 years, 2 months ago (2013-10-04 21:05:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/25954005/1
7 years, 2 months ago (2013-10-04 22:21:08 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-10-05 00:19:49 UTC) #5
Message was sent while issue was closed.
Change committed as 227148

Powered by Google App Engine
This is Rietveld 408576698