Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2658853003: Remove the deprecated Alt+Shift shortcut completely (Closed)

Created:
3 years, 11 months ago by afakhry
Modified:
3 years, 10 months ago
Reviewers:
James Cook, Mark P
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the deprecated Alt+Shift shortcut completely The Alt+shift showtcut was disabled in M53, but since then we kept its deprecation notification. Now it's time to remove it entirely in M58. BUG=672905 TEST=manually, Alt+Shift should still do nothing, and should show no notification. Review-Url: https://codereview.chromium.org/2658853003 Cr-Commit-Position: refs/heads/master@{#447013} Committed: https://chromium.googlesource.com/chromium/src/+/bd98638fcb71657f577d763ae2099f30be6df7d7

Patch Set 1 #

Total comments: 4

Patch Set 2 : James' comments #

Total comments: 6

Patch Set 3 : More comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -84 lines) Patch
M ash/ash_chromeos_strings.grdp View 2 chunks +0 lines, -10 lines 0 comments Download
M ash/common/accelerators/accelerator_controller.h View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M ash/common/accelerators/accelerator_controller.cc View 1 2 3 chunks +50 lines, -57 lines 0 comments Download
M ash/common/accelerators/accelerator_table.cc View 2 chunks +2 lines, -15 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
afakhry
James, can you please review this CL? Thanks!
3 years, 11 months ago (2017-01-26 21:41:27 UTC) #6
James Cook
Hooray for killing old, inconsistent shortcuts! https://codereview.chromium.org/2658853003/diff/1/ash/common/accelerators/accelerator_controller.cc File ash/common/accelerators/accelerator_controller.cc (right): https://codereview.chromium.org/2658853003/diff/1/ash/common/accelerators/accelerator_controller.cc#newcode631 ash/common/accelerators/accelerator_controller.cc:631: if (delegate_) { ...
3 years, 11 months ago (2017-01-26 22:24:52 UTC) #7
afakhry
https://codereview.chromium.org/2658853003/diff/1/ash/common/accelerators/accelerator_controller.cc File ash/common/accelerators/accelerator_controller.cc (right): https://codereview.chromium.org/2658853003/diff/1/ash/common/accelerators/accelerator_controller.cc#newcode631 ash/common/accelerators/accelerator_controller.cc:631: if (delegate_) { On 2017/01/26 22:24:52, James Cook wrote: ...
3 years, 10 months ago (2017-01-27 03:35:06 UTC) #10
James Cook
https://codereview.chromium.org/2658853003/diff/20001/ash/common/accelerators/accelerator_controller.cc File ash/common/accelerators/accelerator_controller.cc (right): https://codereview.chromium.org/2658853003/diff/20001/ash/common/accelerators/accelerator_controller.cc#newcode623 ash/common/accelerators/accelerator_controller.cc:623: if (!MaybeDeprecatedAcceleratorPressed(action, accelerator)) nit: I wonder if there's a ...
3 years, 10 months ago (2017-01-27 16:40:30 UTC) #13
afakhry
https://codereview.chromium.org/2658853003/diff/20001/ash/common/accelerators/accelerator_controller.cc File ash/common/accelerators/accelerator_controller.cc (right): https://codereview.chromium.org/2658853003/diff/20001/ash/common/accelerators/accelerator_controller.cc#newcode623 ash/common/accelerators/accelerator_controller.cc:623: if (!MaybeDeprecatedAcceleratorPressed(action, accelerator)) On 2017/01/27 16:40:30, James Cook wrote: ...
3 years, 10 months ago (2017-01-27 17:27:41 UTC) #14
James Cook
I like it! LGTM
3 years, 10 months ago (2017-01-27 18:55:37 UTC) #15
afakhry
+mpearson@ for histograms.xml
3 years, 10 months ago (2017-01-27 19:59:47 UTC) #17
Mark P
histograms.xml lgtm rubber stamp
3 years, 10 months ago (2017-01-28 06:17:18 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658853003/40001
3 years, 10 months ago (2017-01-30 16:55:34 UTC) #20
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 18:07:44 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bd98638fcb71657f577d763ae209...

Powered by Google App Engine
This is Rietveld 408576698