Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2658853002: [turbofan] Don't try to optimize tail calls to .apply. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Don't try to optimize tail calls to .apply. BUG=chromium:685634 R=ishell@chromium.org Review-Url: https://codereview.chromium.org/2658853002 Cr-Commit-Position: refs/heads/master@{#42713} Committed: https://chromium.googlesource.com/v8/v8/+/7be3b4c90f93405ae9875f2403341b5684fb4e14

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M src/compiler/js-call-reducer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-685634.js View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-26 17:01:30 UTC) #1
Igor Sheludko
lgtm
3 years, 11 months ago (2017-01-26 17:15:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658853002/1
3 years, 11 months ago (2017-01-26 20:50:46 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 20:52:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7be3b4c90f93405ae9875f2403341b5684f...

Powered by Google App Engine
This is Rietveld 408576698