Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2658803002: [Compiler] Put background compilation of eager inner functions behind a flag. (Closed)

Created:
3 years, 11 months ago by rmcilroy
Modified:
3 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Compiler] Put background compilation of eager inner functions behind a flag. Disabled until clusterfuzz issues are sorted. BUG=v8:5203, v8:5215, chromium:685515, chromium:685476 Review-Url: https://codereview.chromium.org/2658803002 Cr-Commit-Position: refs/heads/master@{#42686} Committed: https://chromium.googlesource.com/v8/v8/+/647d7b6c33e8cc37e3c189c717eeab8566e6a656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/compiler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
rmcilroy
Michi could you please take a look?
3 years, 11 months ago (2017-01-26 09:52:13 UTC) #4
Michael Starzinger
LGTM (rubber-stamped).
3 years, 11 months ago (2017-01-26 09:54:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658803002/1
3 years, 11 months ago (2017-01-26 09:56:00 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 10:27:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/647d7b6c33e8cc37e3c189c717eeab8566e...

Powered by Google App Engine
This is Rietveld 408576698