Issue 26588002: Remove support for -webkit-line-clamp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26588002: Remove support for -webkit-line-clamp

Created:
7 years, 2 months ago by cbiesinger

Modified:
7 years, 2 months ago

Reviewers:

CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove support for -webkit-line-clamp It only works together with the deprecated flexbox (-webkit-box) BUG=305376

Patch Set 1 #

Patch Set 2 : fix "base files missing"? #

Patch Set 3 : remove some tests #

Patch Set 4 : fix tests #

Patch Set 5 : Base files missing... #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -736 lines)			Patch
M	LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/fast/css/getComputedStyle/resources/property-names.js	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
D	LayoutTests/fast/flexbox/line-clamp-link-after-ellipsis.html	View	1 2	1 chunk	+0 lines, -40 lines	0 comments	Download
D	LayoutTests/fast/flexbox/line-clamp-link-after-ellipsis-expected.txt	View	1 2	1 chunk	+0 lines, -12 lines	0 comments	Download
D	LayoutTests/fast/flexbox/line-clamp-removed-dynamically.html	View	1 2	1 chunk	+0 lines, -15 lines	0 comments	Download
D	LayoutTests/fast/flexbox/line-clamp-removed-dynamically-expected.html	View	1 2	1 chunk	+0 lines, -10 lines	0 comments	Download
D	LayoutTests/fast/overflow/line-clamp.html	View	1 2	1 chunk	+0 lines, -46 lines	0 comments	Download
D	LayoutTests/fast/overflow/line-clamp-and-columns.html	View	1 2	1 chunk	+0 lines, -16 lines	0 comments	Download
D	LayoutTests/fast/overflow/line-clamp-and-columns-expected.txt	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
D	LayoutTests/platform/linux/fast/overflow/line-clamp-expected.png	View	1 2	Binary file		0 comments	Download
D	LayoutTests/platform/mac/fast/overflow/line-clamp-expected.png	View	1 2	Binary file		0 comments	Download
D	LayoutTests/platform/mac/fast/overflow/line-clamp-expected.txt	View	1 2	1 chunk	+0 lines, -153 lines	0 comments	Download
D	LayoutTests/platform/win/fast/overflow/line-clamp-expected.png	View	1 2	Binary file		0 comments	Download
D	LayoutTests/platform/win/fast/overflow/line-clamp-expected.txt	View	1 2	1 chunk	+0 lines, -153 lines	0 comments	Download
M	LayoutTests/svg/css/getComputedStyle-basic-expected.txt	View	1 2	2 chunks	+0 lines, -4 lines	0 comments	Download
M	LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/webexposed/css-properties-as-js-properties-expected.txt	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/css/CSSComputedStyleDeclaration.cpp	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	Source/core/css/CSSParser-in.cpp	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	Source/core/css/CSSPrimitiveValueMappings.h	View		2 chunks	+0 lines, -20 lines	0 comments	Download
M	Source/core/css/CSSProperties.in	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/css/CSSProperty.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/css/CSSPropertyNames.in	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/css/resolver/StyleBuilderCustom.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/page/UseCounter.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/page/UseCounter.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/rendering/EllipsisBox.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/RenderBlock.cpp	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	Source/core/rendering/RenderDeprecatedFlexibleBox.h	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	Source/core/rendering/RenderDeprecatedFlexibleBox.cpp	View		4 chunks	+1 line, -136 lines	0 comments	Download
M	Source/core/rendering/RenderLayer.cpp	View	1 2 3	2 chunks	+3 lines, -12 lines	0 comments	Download
D	Source/core/rendering/style/LineClampValue.h	View		1 chunk	+0 lines, -69 lines	0 comments	Download
M	Source/core/rendering/style/RenderStyle.h	View		4 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/core/rendering/style/RenderStyle.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/rendering/style/RenderStyleConstants.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/rendering/style/StyleRareNonInheritedData.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/core/rendering/style/StyleRareNonInheritedData.cpp	View		3 chunks	+0 lines, -3 lines	0 comments	Download