Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2658783006: Add offset contributed to sticky position box rect by location containers (Closed)

Created:
3 years, 10 months ago by flackr
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Add offset contributed to sticky position box rect by location containers Tables are constructed using locationContainers which do not serve as the containing block but do offset the element. These need to be included in the sticky position offsets in the constraints. BUG=673538 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2646133002 Cr-Commit-Position: refs/heads/master@{#446155} (cherry picked from commit 686dbbef585fd2064f1a2a3451b90e501936a589) Review-Url: https://codereview.chromium.org/2658783006 . Cr-Commit-Position: refs/branch-heads/2987@{#151} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/6781957c4f6c0199918d826c3e5a39bd3c7696bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -10 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 2 chunks +15 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp View 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +16 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
flackr
3 years, 10 months ago (2017-01-27 18:03:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6781957c4f6c0199918d826c3e5a39bd3c7696bf.

Powered by Google App Engine
This is Rietveld 408576698