Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2658773002: Revert of Restore auto-launched state on kiosk restart within session (Closed)

Created:
3 years, 11 months ago by kjellander_chromium
Modified:
3 years, 11 months ago
Reviewers:
xiyuan, tbarzic
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Restore auto-launched state on kiosk restart within session (patchset #6 id:100001 of https://codereview.chromium.org/2639033002/ ) Reason for revert: browser_tests test AutoLaunchedKioskTest.PRE_CrashRestore starts timing out reliably with this CL, starting with https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/32762 Original issue's description: > Restore auto-launched state on kiosk restart within session > > When kiosk app is restarted within a kiosk session - e.g. due to crash, > app's auto-launched state has to be preserved. Previously auto-launched > state was kept only in memory - if kiosk was restarted, the information > would get lost. > This CL is attempt to fix the problem by preserving auto-launched state > by setting a user session scoped flag that indicates that the kiosk app > is auto-launched (newly introduced app-auto-launched). The flag will be > scoped to current used session, and will be passed to Chrome in a case > Chrome restarts withing the user session. On restart, the flag can be > used to deduce whether the kiosk app should be considered auto-launched > or not. > > Note that when setting the auto-launched flag, it's important to > consider current set of policy defined flags - they should be > preserved when auto-launched flag is added to set of user flags. > > BUG=677340 > > Review-Url: https://codereview.chromium.org/2639033002 > Cr-Commit-Position: refs/heads/master@{#446166} > Committed: https://chromium.googlesource.com/chromium/src/+/663f7dfaa3b96b353ade5b9ce6b7616e51ba73bb TBR=xiyuan@chromium.org,tbarzic@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=677340 Review-Url: https://codereview.chromium.org/2658773002 Cr-Commit-Position: refs/heads/master@{#446240} Committed: https://chromium.googlesource.com/chromium/src/+/92ebeda78b7d6e27e7afa0ef44c82140ce682441

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -576 lines) Patch
M chrome/browser/chromeos/app_mode/kiosk_app_manager.h View 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_manager.cc View 4 chunks +0 lines, -70 lines 0 comments Download
A chrome/browser/chromeos/app_mode/kiosk_crash_restore_browsertest.cc View 1 chunk +194 lines, -0 lines 0 comments Download
D chrome/browser/chromeos/login/auto_launched_kiosk_browsertest.cc View 1 chunk +0 lines, -470 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kjellander_chromium
Created Revert of Restore auto-launched state on kiosk restart within session
3 years, 11 months ago (2017-01-26 05:44:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658773002/1
3 years, 11 months ago (2017-01-26 05:45:04 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 05:47:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/92ebeda78b7d6e27e7afa0ef44c8...

Powered by Google App Engine
This is Rietveld 408576698