Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2658723002: MD Settings: Remove some ES6 leftovers from CrOS code that break uglify. (Closed)

Created:
3 years, 11 months ago by dpapad
Modified:
3 years, 11 months ago
Reviewers:
stevenjb, Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, Dan Beam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Remove some ES6 leftovers from CrOS code that break uglify. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2658723002 Cr-Commit-Position: refs/heads/master@{#446251} Committed: https://chromium.googlesource.com/chromium/src/+/0dca64e43351279355d64d5d612e33d388d583d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/device_page/device_page.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/device_page/display.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_page.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/languages_page/manage_input_methods_page.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/people_page/camera.js View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
dpapad
3 years, 11 months ago (2017-01-26 02:34:55 UTC) #5
stevenjb
lgtm
3 years, 11 months ago (2017-01-26 02:48:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658723002/1
3 years, 11 months ago (2017-01-26 05:40:18 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/350756)
3 years, 11 months ago (2017-01-26 05:43:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658723002/1
3 years, 11 months ago (2017-01-26 05:50:33 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 06:28:36 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0dca64e43351279355d64d5d612e...

Powered by Google App Engine
This is Rietveld 408576698