Make WTFString constructor that takes const char* call strlen inline

Make WTFString constructor that takes const char* call strlen inline

This allows us to optimize away strlens for creating String from
literal strings. (This actually showed up on my local profiling)

BUG=673376
Review-Url: https://codereview.chromium.org/2658703005
Cr-Commit-Position: refs/heads/master@{#446670}
Committed: https://chromium.googlesource.com/chromium/src/+/e973df73509337cabf6122bb4e15aa5a806e38b4

[kinuko, 2017-01-27 07:05:46]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 07:06:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2017-01-27 07:06:18]

Description was changed from

==========
Make WTFString constructor that takes const char* call strlen inline

This allows us to optimize away strlens for creating String from
literal strings. (This actually showed up on my local profiling)

BUG=673376
==========

to

==========
Make WTFString constructor that takes const char* call strlen inline

This allows us to optimize away strlens for creating String from
literal strings. (This actually showed up on my local profiling)

BUG=673376
==========

[kinuko, 2017-01-27 07:06:18]

kinuko@chromium.org changed reviewers:
+ csharrison@chromium.org, esprehn@chromium.org

[kinuko, 2017-01-27 07:07:28]

Another similar change to the other WebString one.  What do you think?

[commit-bot: I haz the power, 2017-01-27 08:50:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 08:50:35]

Dry run: This issue passed the CQ dry run.

[esprehn, 2017-01-27 09:25:51]

lgtm

https://codereview.chromium.org/2658703005/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/text/WTFString.h (right):

https://codereview.chromium.org/2658703005/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/text/WTFString.h:94: : String(characters,
Delegate to the other constructor.

: String(reinterpret_cast...) {}

[kinuko, 2017-01-27 12:52:24]

https://codereview.chromium.org/2658703005/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/text/WTFString.h (right):

https://codereview.chromium.org/2658703005/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/text/WTFString.h:94: : String(characters,
On 2017/01/27 09:25:51, esprehn wrote:
> Delegate to the other constructor.
> 
> : String(reinterpret_cast...) {}

Good idea, done.

[kinuko, 2017-01-27 12:52:42]

The CQ bit was checked by kinuko@chromium.org

[kinuko, 2017-01-27 12:52:42]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2658703005/#ps20001
(title: "delegate ctor")

[commit-bot: I haz the power, 2017-01-27 12:52:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2017-01-27 13:25:43]

LGTM 2

[commit-bot: I haz the power, 2017-01-27 15:15:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485521562198930,
"parent_rev": "957d660ec8e4ae6d616b34d4b2b85bd97767d362", "commit_rev":
"e973df73509337cabf6122bb4e15aa5a806e38b4"}

[commit-bot: I haz the power, 2017-01-27 15:15:34]

Description was changed from

==========
Make WTFString constructor that takes const char* call strlen inline

This allows us to optimize away strlens for creating String from
literal strings. (This actually showed up on my local profiling)

BUG=673376
==========

to

==========
Make WTFString constructor that takes const char* call strlen inline

This allows us to optimize away strlens for creating String from
literal strings. (This actually showed up on my local profiling)

BUG=673376

Review-Url: https://codereview.chromium.org/2658703005
Cr-Commit-Position: refs/heads/master@{#446670}
Committed:
https://chromium.googlesource.com/chromium/src/+/e973df73509337cabf6122bb4e15...
==========

[commit-bot: I haz the power, 2017-01-27 15:15:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e973df73509337cabf6122bb4e15...