Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2658703003: [wasm][asm.js] Add wasm module size to asm debug measurements. (Closed)

Created:
3 years, 11 months ago by bradnelson
Modified:
3 years, 11 months ago
Reviewers:
Mircea Trofin, bradn
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Add wasm module size to asm debug measurements. Also show size when --trace-asm-time is on. BUG= R=mtrofin@chromium.org Review-Url: https://codereview.chromium.org/2658703003 Cr-Commit-Position: refs/heads/master@{#42678} Committed: https://chromium.googlesource.com/v8/v8/+/f6d0dc6d889f70890a8ee6f00091d14f0ef6199a

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/asmjs/asm-js.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
bradn
3 years, 11 months ago (2017-01-26 07:17:58 UTC) #4
Mircea Trofin
On 2017/01/26 07:17:58, bradn wrote: lgtm, 1 nit
3 years, 11 months ago (2017-01-26 07:19:24 UTC) #5
Mircea Trofin
https://codereview.chromium.org/2658703003/diff/1/src/asmjs/asm-js.cc File src/asmjs/asm-js.cc (right): https://codereview.chromium.org/2658703003/diff/1/src/asmjs/asm-js.cc#newcode194 src/asmjs/asm-js.cc:194: uintptr_t wasm_size = module->end() - module->begin(); DCHECK end >= ...
3 years, 11 months ago (2017-01-26 07:19:31 UTC) #6
bradn
https://codereview.chromium.org/2658703003/diff/1/src/asmjs/asm-js.cc File src/asmjs/asm-js.cc (right): https://codereview.chromium.org/2658703003/diff/1/src/asmjs/asm-js.cc#newcode194 src/asmjs/asm-js.cc:194: uintptr_t wasm_size = module->end() - module->begin(); On 2017/01/26 07:19:31, ...
3 years, 11 months ago (2017-01-26 07:46:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658703003/20001
3 years, 11 months ago (2017-01-26 07:46:44 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 08:17:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/f6d0dc6d889f70890a8ee6f00091d14f0ef...

Powered by Google App Engine
This is Rietveld 408576698