Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2658693005: Fixes compile and gn-check errors with enable_plugins=false. (Closed)

Created:
3 years, 11 months ago by alokp
Modified:
3 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews, jam, wjmaclean, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes compile and gn-check errors with enable_plugins=false. The component build for content_unittests and content_browsertests were broken with enable_plugins=false on linux. BUG=666790 Review-Url: https://codereview.chromium.org/2658693005 Cr-Commit-Position: refs/heads/master@{#446483} Committed: https://chromium.googlesource.com/chromium/src/+/e3ec364721fe2d782df068cbdd7785e4d47365fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M content/browser/storage_partition_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/child/BUILD.gn View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
alokp
3 years, 11 months ago (2017-01-26 18:21:09 UTC) #2
brettw
lgtm
3 years, 11 months ago (2017-01-26 22:28:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658693005/1
3 years, 11 months ago (2017-01-26 22:56:51 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 23:05:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e3ec364721fe2d782df068cbdd77...

Powered by Google App Engine
This is Rietveld 408576698