Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2658643005: Added report URLs to the dashboard. (Closed)

Created:
3 years, 10 months ago by jessimb
Modified:
3 years, 10 months ago
Reviewers:
eakuefner, sullivan
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Added report URLs to the dashboard. Changed the test names to link to their corresponding /report page. http://i.imgur.com/aPfbE0u.png BUG=catapult:#3141 Review-Url: https://codereview.chromium.org/2658643005 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/8c5f79979fb59652f150d78bdb2b78c51f2d12fd

Patch Set 1 #

Patch Set 2 : Updating tests. #

Patch Set 3 : updating to match the pared down version #

Patch Set 4 : removing more _* and fixing instantiation test #

Total comments: 4

Patch Set 5 : response to comments #

Patch Set 6 : set upstream to track master #

Patch Set 7 : resolving merge conficts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -1 line) Patch
M dashboard/dashboard/elements/speed-releasing-table.html View 1 2 3 4 5 6 3 chunks +10 lines, -1 line 0 comments Download
M dashboard/dashboard/elements/speed-releasing-table-test.html View 1 2 3 4 5 6 2 chunks +14 lines, -0 lines 0 comments Download
M dashboard/dashboard/speed_releasing.py View 1 2 3 4 5 6 3 chunks +26 lines, -0 lines 0 comments Download
M dashboard/dashboard/speed_releasing_test.py View 1 2 3 4 5 6 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
jessimb
PTAL I have updated this to include the removal of other stats.
3 years, 10 months ago (2017-02-03 18:16:11 UTC) #6
eakuefner
https://codereview.chromium.org/2658643005/diff/60001/dashboard/dashboard/elements/speed-releasing-table.html File dashboard/dashboard/elements/speed-releasing-table.html (right): https://codereview.chromium.org/2658643005/diff/60001/dashboard/dashboard/elements/speed-releasing-table.html#newcode132 dashboard/dashboard/elements/speed-releasing-table.html:132: oops? https://codereview.chromium.org/2658643005/diff/60001/dashboard/dashboard/speed_releasing.py File dashboard/dashboard/speed_releasing.py (right): https://codereview.chromium.org/2658643005/diff/60001/dashboard/dashboard/speed_releasing.py#newcode166 dashboard/dashboard/speed_releasing.py:166: if len(test.split('/')) ...
3 years, 10 months ago (2017-02-03 18:32:04 UTC) #7
jessimb
PTAL https://codereview.chromium.org/2658643005/diff/60001/dashboard/dashboard/elements/speed-releasing-table.html File dashboard/dashboard/elements/speed-releasing-table.html (right): https://codereview.chromium.org/2658643005/diff/60001/dashboard/dashboard/elements/speed-releasing-table.html#newcode132 dashboard/dashboard/elements/speed-releasing-table.html:132: On 2017/02/03 at 18:32:04, eakuefner wrote: > oops? ...
3 years, 10 months ago (2017-02-03 19:42:44 UTC) #8
eakuefner
+Annie lgtm -- please remove the demo link from your description as the demo doesn't ...
3 years, 10 months ago (2017-02-21 22:29:19 UTC) #10
sullivan
lgtm
3 years, 10 months ago (2017-02-22 15:31:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658643005/100001
3 years, 10 months ago (2017-02-22 17:16:08 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Android%20Tryserver/builds/2890) Catapult Linux ...
3 years, 10 months ago (2017-02-22 17:17:18 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658643005/120001
3 years, 10 months ago (2017-02-22 18:42:53 UTC) #19
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 19:11:50 UTC) #22
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698