Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Unified Diff: device/vr/android/gvr/gvr_device_provider.h

Issue 2658643003: Refactor GvrDelegate ownership into GvrDelegateProvider and fix more threading violations. (Closed)
Patch Set: Address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/vr/android/gvr/gvr_device.cc ('k') | device/vr/android/gvr/gvr_device_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/vr/android/gvr/gvr_device_provider.h
diff --git a/device/vr/android/gvr/gvr_device_provider.h b/device/vr/android/gvr/gvr_device_provider.h
index 6bbef04dff5ab38dee6caa92ddffa1f71e96e132..5793021566859838b80056bb5871fdc0cc82756f 100644
--- a/device/vr/android/gvr/gvr_device_provider.h
+++ b/device/vr/android/gvr/gvr_device_provider.h
@@ -14,7 +14,6 @@
namespace device {
-class GvrDelegate;
class GvrDevice;
class DEVICE_VR_EXPORT GvrDeviceProvider : public VRDeviceProvider {
@@ -31,20 +30,11 @@ class DEVICE_VR_EXPORT GvrDeviceProvider : public VRDeviceProvider {
void RequestPresent(const base::Callback<void(bool)>& callback);
void ExitPresent();
- void OnGvrDelegateReady(GvrDelegate* delegate);
- void OnGvrDelegateRemoved();
-
- // TODO(mthiesse): Make the NonPresentingDelegate owned by this class so that
- // it cannot be removed.
- void OnNonPresentingDelegateRemoved();
- void OnDisplayBlur();
- void OnDisplayFocus();
- void OnDisplayActivate();
+ GvrDevice* Device() { return vr_device_.get(); }
private:
- void SwitchToNonPresentingDelegate();
-
std::unique_ptr<GvrDevice> vr_device_;
+ bool initialized_ = false;
DISALLOW_COPY_AND_ASSIGN(GvrDeviceProvider);
};
« no previous file with comments | « device/vr/android/gvr/gvr_device.cc ('k') | device/vr/android/gvr/gvr_device_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698