Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: device/vr/android/gvr/gvr_device_provider.h

Issue 2658643003: Refactor GvrDelegate ownership into GvrDelegateProvider and fix more threading violations. (Closed)
Patch Set: Address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « device/vr/android/gvr/gvr_device.cc ('k') | device/vr/android/gvr/gvr_device_provider.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DEVICE_VR_ANDROID_GVR_DEVICE_PROVIDER_H 5 #ifndef DEVICE_VR_ANDROID_GVR_DEVICE_PROVIDER_H
6 #define DEVICE_VR_ANDROID_GVR_DEVICE_PROVIDER_H 6 #define DEVICE_VR_ANDROID_GVR_DEVICE_PROVIDER_H
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "device/vr/vr_device_provider.h" 12 #include "device/vr/vr_device_provider.h"
13 #include "device/vr/vr_export.h" 13 #include "device/vr/vr_export.h"
14 14
15 namespace device { 15 namespace device {
16 16
17 class GvrDelegate;
18 class GvrDevice; 17 class GvrDevice;
19 18
20 class DEVICE_VR_EXPORT GvrDeviceProvider : public VRDeviceProvider { 19 class DEVICE_VR_EXPORT GvrDeviceProvider : public VRDeviceProvider {
21 public: 20 public:
22 GvrDeviceProvider(); 21 GvrDeviceProvider();
23 ~GvrDeviceProvider() override; 22 ~GvrDeviceProvider() override;
24 23
25 void GetDevices(std::vector<VRDevice*>* devices) override; 24 void GetDevices(std::vector<VRDevice*>* devices) override;
26 void Initialize() override; 25 void Initialize() override;
27 26
28 void SetListeningForActivate(bool listening) override; 27 void SetListeningForActivate(bool listening) override;
29 28
30 // Called from GvrDevice. 29 // Called from GvrDevice.
31 void RequestPresent(const base::Callback<void(bool)>& callback); 30 void RequestPresent(const base::Callback<void(bool)>& callback);
32 void ExitPresent(); 31 void ExitPresent();
33 32
34 void OnGvrDelegateReady(GvrDelegate* delegate); 33 GvrDevice* Device() { return vr_device_.get(); }
35 void OnGvrDelegateRemoved();
36
37 // TODO(mthiesse): Make the NonPresentingDelegate owned by this class so that
38 // it cannot be removed.
39 void OnNonPresentingDelegateRemoved();
40 void OnDisplayBlur();
41 void OnDisplayFocus();
42 void OnDisplayActivate();
43 34
44 private: 35 private:
45 void SwitchToNonPresentingDelegate();
46
47 std::unique_ptr<GvrDevice> vr_device_; 36 std::unique_ptr<GvrDevice> vr_device_;
37 bool initialized_ = false;
48 38
49 DISALLOW_COPY_AND_ASSIGN(GvrDeviceProvider); 39 DISALLOW_COPY_AND_ASSIGN(GvrDeviceProvider);
50 }; 40 };
51 41
52 } // namespace device 42 } // namespace device
53 43
54 #endif // DEVICE_VR_ANDROID_GVR_DEVICE_PROVIDER_H 44 #endif // DEVICE_VR_ANDROID_GVR_DEVICE_PROVIDER_H
OLDNEW
« no previous file with comments | « device/vr/android/gvr/gvr_device.cc ('k') | device/vr/android/gvr/gvr_device_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698