chrome/browser/android/vr_shell/vr_compositor.h - Issue 2658643003: Refactor GvrDelegate ownership into GvrDelegateProvider and fix more threading violations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/vr_shell/vr_compositor.h

Issue 2658643003: Refactor GvrDelegate ownership into GvrDelegateProvider and fix more threading violations. (Closed)

Patch Set: Address comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/vr_shell/vr_compositor.h

diff --git a/chrome/browser/android/vr_shell/vr_compositor.h b/chrome/browser/android/vr_shell/vr_compositor.h

index 7238ad88034c8135910238d86f699f7ad866a648..20aac81a028689ccbf1c6fd84bc08042932b8c8b 100644

--- a/chrome/browser/android/vr_shell/vr_compositor.h

+++ b/chrome/browser/android/vr_shell/vr_compositor.h

@@ -36,7 +36,6 @@ class VrCompositor : public content::CompositorClient {

void SurfaceDestroyed();

void SetWindowBounds(gfx::Size size);

- gfx::Size GetWindowBounds() { return bounds_; }

void SurfaceChanged(jobject surface);

void SetLayer(content::WebContents* web_contents);

@@ -48,7 +47,6 @@ class VrCompositor : public content::CompositorClient {

void RestoreLayer();

std::unique_ptr<content::Compositor> compositor_;

- gfx::Size bounds_;

cc::Layer* layer_ = nullptr;

cc::Layer* layer_parent_ = nullptr;