chrome/browser/android/vr_shell/vr_compositor.cc - Issue 2658643003: Refactor GvrDelegate ownership into GvrDelegateProvider and fix more threading violations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/vr_shell/vr_compositor.cc

Issue 2658643003: Refactor GvrDelegate ownership into GvrDelegateProvider and fix more threading violations. (Closed)

Patch Set: Address comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/vr_shell/vr_compositor.cc

diff --git a/chrome/browser/android/vr_shell/vr_compositor.cc b/chrome/browser/android/vr_shell/vr_compositor.cc

index e386d90180d14204e4ac1e80b8b90ff615f0fb42..f22271aed3c87278a9b9c727aab1ea0233536996 100644

--- a/chrome/browser/android/vr_shell/vr_compositor.cc

+++ b/chrome/browser/android/vr_shell/vr_compositor.cc

@@ -59,8 +59,7 @@ void VrCompositor::SurfaceDestroyed() {

}

void VrCompositor::SetWindowBounds(gfx::Size size) {

- bounds_ = size;

- compositor_->SetWindowBounds(bounds_);

+ compositor_->SetWindowBounds(size);

}

void VrCompositor::SurfaceChanged(jobject surface) {