Chromium Code Reviews
DescriptionRevert of Fix potential shutdown deadlock in UI service (patchset #2 id:20001 of https://codereview.chromium.org/2651443002/ )
Reason for revert:
Bisect by tzik@ suggests it could be the culprit for tsan builder failing, e.g. https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%20Tests/builds/581/steps/content_browsertests/logs/RenderThreadImplBrowserTest.InputHandlerManagerDestroyedAfterCompositorThread
Original issue's description:
> Fix potential shutdown deadlock in UI service
>
> If the GpuPtr is disconnected while there are pending buffer allocations
> in flight, this can lead to the main thread deadlocking on a WaitableEvent
> that never signals.
>
> Fixes that by tracking pending allocations and ensuring they're always
> signalled on connection error or other shutdown events.
>
> BUG=
> R=sadrul@chromium.org
>
> Review-Url: https://codereview.chromium.org/2651443002
> Cr-Commit-Position: refs/heads/master@{#445434}
> Committed: https://chromium.googlesource.com/chromium/src/+/d0e46de3ff797f53376fa63297a5d41241568fdf
TBR=sadrul@chromium.org,rockot@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=685157
Patch Set 1 #
Messages
Total messages: 9 (5 generated)
|
||||||||||||||||||||||||||||