Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2658603004: Revert of Fix potential shutdown deadlock in UI service (Closed)

Created:
3 years, 11 months ago by mastiz
Modified:
3 years, 11 months ago
CC:
chromium-reviews, piman+watch_chromium.org, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix potential shutdown deadlock in UI service (patchset #2 id:20001 of https://codereview.chromium.org/2651443002/ ) Reason for revert: Bisect by tzik@ suggests it could be the culprit for tsan builder failing, e.g. https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%20Tests/builds/581/steps/content_browsertests/logs/RenderThreadImplBrowserTest.InputHandlerManagerDestroyedAfterCompositorThread Original issue's description: > Fix potential shutdown deadlock in UI service > > If the GpuPtr is disconnected while there are pending buffer allocations > in flight, this can lead to the main thread deadlocking on a WaitableEvent > that never signals. > > Fixes that by tracking pending allocations and ensuring they're always > signalled on connection error or other shutdown events. > > BUG= > R=sadrul@chromium.org > > Review-Url: https://codereview.chromium.org/2651443002 > Cr-Commit-Position: refs/heads/master@{#445434} > Committed: https://chromium.googlesource.com/chromium/src/+/d0e46de3ff797f53376fa63297a5d41241568fdf TBR=sadrul@chromium.org,rockot@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=685157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -36 lines) Patch
M services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.h View 3 chunks +0 lines, -8 lines 0 comments Download
M services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.cc View 3 chunks +8 lines, -28 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mastiz
Created Revert of Fix potential shutdown deadlock in UI service
3 years, 11 months ago (2017-01-25 14:49:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658603004/1
3 years, 11 months ago (2017-01-25 14:49:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658603004/1
3 years, 11 months ago (2017-01-25 14:50:00 UTC) #7
Ken Rockot(use gerrit already)
3 years, 11 months ago (2017-01-25 15:07:38 UTC) #8
On 2017/01/25 at 14:50:00, commit-bot wrote:
> CQ is trying da patch. Follow status at
>  
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

We generally do not revert for non-tree-closing issues. This CL can't be
reverted as-is because there are dependent patches which have since landed.

It's been on ToT for at least a day, so I will take a look at it over the next
hour and prepare a fix if it is indeed the culprit.

Powered by Google App Engine
This is Rietveld 408576698