Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.h

Issue 2658603004: Revert of Fix potential shutdown deadlock in UI service (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SERVICES_UI_PUBLIC_CPP_GPU_CLIENT_GPU_MEMORY_BUFFER_MANAGER_H_ 5 #ifndef SERVICES_UI_PUBLIC_CPP_GPU_CLIENT_GPU_MEMORY_BUFFER_MANAGER_H_
6 #define SERVICES_UI_PUBLIC_CPP_GPU_CLIENT_GPU_MEMORY_BUFFER_MANAGER_H_ 6 #define SERVICES_UI_PUBLIC_CPP_GPU_CLIENT_GPU_MEMORY_BUFFER_MANAGER_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <set>
10 #include <vector> 9 #include <vector>
11 10
12 #include "base/macros.h" 11 #include "base/macros.h"
13 #include "base/memory/ref_counted.h" 12 #include "base/memory/ref_counted.h"
14 #include "base/memory/weak_ptr.h" 13 #include "base/memory/weak_ptr.h"
15 #include "base/threading/thread.h" 14 #include "base/threading/thread.h"
16 #include "gpu/command_buffer/client/gpu_memory_buffer_manager.h" 15 #include "gpu/command_buffer/client/gpu_memory_buffer_manager.h"
17 #include "services/ui/public/interfaces/gpu.mojom.h" 16 #include "services/ui/public/interfaces/gpu.mojom.h"
18 17
19 namespace base { 18 namespace base {
20 class WaitableEvent; 19 class WaitableEvent;
21 } 20 }
22 21
23 namespace ui { 22 namespace ui {
24 23
25 class ClientGpuMemoryBufferManager : public gpu::GpuMemoryBufferManager { 24 class ClientGpuMemoryBufferManager : public gpu::GpuMemoryBufferManager {
26 public: 25 public:
27 explicit ClientGpuMemoryBufferManager(mojom::GpuPtr gpu); 26 explicit ClientGpuMemoryBufferManager(mojom::GpuPtr gpu);
28 ~ClientGpuMemoryBufferManager() override; 27 ~ClientGpuMemoryBufferManager() override;
29 28
30 private: 29 private:
31 void InitThread(mojom::GpuPtrInfo gpu_info); 30 void InitThread(mojom::GpuPtrInfo gpu_info);
32 void TearDownThread(); 31 void TearDownThread();
33 void DisconnectGpuOnThread();
34 void AllocateGpuMemoryBufferOnThread(const gfx::Size& size, 32 void AllocateGpuMemoryBufferOnThread(const gfx::Size& size,
35 gfx::BufferFormat format, 33 gfx::BufferFormat format,
36 gfx::BufferUsage usage, 34 gfx::BufferUsage usage,
37 gfx::GpuMemoryBufferHandle* handle, 35 gfx::GpuMemoryBufferHandle* handle,
38 base::WaitableEvent* wait); 36 base::WaitableEvent* wait);
39 void OnGpuMemoryBufferAllocatedOnThread(
40 gfx::GpuMemoryBufferHandle* ret_handle,
41 base::WaitableEvent* wait,
42 const gfx::GpuMemoryBufferHandle& handle);
43 void DeletedGpuMemoryBuffer(gfx::GpuMemoryBufferId id, 37 void DeletedGpuMemoryBuffer(gfx::GpuMemoryBufferId id,
44 const gpu::SyncToken& sync_token); 38 const gpu::SyncToken& sync_token);
45 39
46 // Overridden from gpu::GpuMemoryBufferManager: 40 // Overridden from gpu::GpuMemoryBufferManager:
47 std::unique_ptr<gfx::GpuMemoryBuffer> CreateGpuMemoryBuffer( 41 std::unique_ptr<gfx::GpuMemoryBuffer> CreateGpuMemoryBuffer(
48 const gfx::Size& size, 42 const gfx::Size& size,
49 gfx::BufferFormat format, 43 gfx::BufferFormat format,
50 gfx::BufferUsage usage, 44 gfx::BufferUsage usage,
51 gpu::SurfaceHandle surface_handle) override; 45 gpu::SurfaceHandle surface_handle) override;
52 void SetDestructionSyncToken(gfx::GpuMemoryBuffer* buffer, 46 void SetDestructionSyncToken(gfx::GpuMemoryBuffer* buffer,
53 const gpu::SyncToken& sync_token) override; 47 const gpu::SyncToken& sync_token) override;
54
55 int counter_ = 0; 48 int counter_ = 0;
56 // TODO(sad): Explore the option of doing this from an existing thread. 49 // TODO(sad): Explore the option of doing this from an existing thread.
57 base::Thread thread_; 50 base::Thread thread_;
58 mojom::GpuPtr gpu_; 51 mojom::GpuPtr gpu_;
59 base::WeakPtr<ClientGpuMemoryBufferManager> weak_ptr_; 52 base::WeakPtr<ClientGpuMemoryBufferManager> weak_ptr_;
60 std::set<base::WaitableEvent*> pending_allocation_waiters_;
61 base::WeakPtrFactory<ClientGpuMemoryBufferManager> weak_ptr_factory_; 53 base::WeakPtrFactory<ClientGpuMemoryBufferManager> weak_ptr_factory_;
62 54
63 DISALLOW_COPY_AND_ASSIGN(ClientGpuMemoryBufferManager); 55 DISALLOW_COPY_AND_ASSIGN(ClientGpuMemoryBufferManager);
64 }; 56 };
65 57
66 } // namespace ui 58 } // namespace ui
67 59
68 #endif // SERVICES_UI_PUBLIC_CPP_GPU_CLIENT_GPU_MEMORY_BUFFER_MANAGER_H_ 60 #endif // SERVICES_UI_PUBLIC_CPP_GPU_CLIENT_GPU_MEMORY_BUFFER_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698