Issue 2658603002: Revert "Optimizations to IC stub for unoptimized code performance on x64."

Issue 2658603002: Revert "Optimizations to IC stub for unoptimized code performance on x64." (Closed)

Created:
3 years, 11 months ago by Johnni Winther

Modified:
3 years, 11 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org, vm-dev_dartlang.org, erikcorry

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Optimizations to IC stub for unoptimized code performance on x64." This reverts commit f03f62ad09be3132f5d086ae2852ef617b94dda9. Committed: https://github.com/dart-lang/sdk/commit/e96d37e815a7ed3a2cff8fcc175f0520c05d55a9

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+290 lines, -324 lines)			Patch
M	runtime/vm/assembler_ia32.cc	View	1 chunk	+13 lines, -41 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1 chunk	+17 lines, -44 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	5 chunks	+45 lines, -44 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View	6 chunks	+44 lines, -36 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	5 chunks	+59 lines, -60 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	7 chunks	+53 lines, -46 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	5 chunks	+58 lines, -46 lines	0 comments	Download

Total messages: 5 (2 generated)

Johnni Winther

Committed patchset #1 (id:1) manually as e96d37e815a7ed3a2cff8fcc175f0520c05d55a9 (presubmit successful).

3 years, 11 months ago (2017-01-25 11:09:28 UTC) #4

Message was sent while issue was closed.

LGTM