Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 2658583006: scheduler: Make DOM window event tasks unthrottled (Closed)

Created:
3 years, 11 months ago by Sami
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

scheduler: Make DOM window event tasks unthrottled This patch avoids throttling events that are routed via DOMWindowEventQueue. This affects a handful of window-related events, the most important ones being IndexedDB events. It turns out many web pages (e.g., Google Docs) rely on IndexedDB transactions to be relatively fast and start encountering errors if they are throttled too aggressively while a tab is in the background. BUG=675372 Review-Url: https://codereview.chromium.org/2651933002 Cr-Commit-Position: refs/heads/master@{#446000} (cherry picked from commit 05a13309259dd16f38eef41adc7cce55e3d15a05) Review-Url: https://codereview.chromium.org/2658583006 . Cr-Commit-Position: refs/branch-heads/2987@{#111} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/e695fd410c82bc1909531ec7cbbfc03f9d6a5d0e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M third_party/WebKit/Source/core/events/DOMWindowEventQueue.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimer.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/SuspendableTimer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/SuspendableTimer.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Sami
3 years, 11 months ago (2017-01-26 18:40:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e695fd410c82bc1909531ec7cbbfc03f9d6a5d0e (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698