Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2658583003: Mojo C++ Bindings: Make SyncHandleRegistry Leaky (Closed)

Created:
3 years, 11 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 11 months ago
Reviewers:
yzshen1
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ Bindings: Make SyncHandleRegistry Leaky This avoids a potential data race on the ThreadLocalPointer if someone happens to leave a Mojo-using thread alive during shutdown. BUG=685157 R=yzshen@chromium.org Review-Url: https://codereview.chromium.org/2658583003 Cr-Commit-Position: refs/heads/master@{#446080} Committed: https://chromium.googlesource.com/chromium/src/+/8499f3a55d732d50c2a743fc3a499c43cc086234

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/public/cpp/bindings/lib/sync_handle_registry.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Ken Rockot(use gerrit already)
PTAL!
3 years, 11 months ago (2017-01-25 17:56:30 UTC) #2
yzshen1
3 years, 11 months ago (2017-01-25 17:59:30 UTC) #4
yzshen1
On 2017/01/25 17:59:30, yzshen1 wrote: LGTM!
3 years, 11 months ago (2017-01-25 17:59:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658583003/1
3 years, 11 months ago (2017-01-25 18:08:35 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 19:23:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8499f3a55d732d50c2a743fc3a49...

Powered by Google App Engine
This is Rietveld 408576698