Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2658583002: Revert of Use associated interface on DownloadedTempFile (Closed)

Created:
3 years, 11 months ago by mastiz
Modified:
3 years, 11 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, kinuko+watch, jsbell+serviceworker_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, loading-reviews_chromium.org, blink-worker-reviews_chromium.org, mlamouri+watch-content_chromium.org, Randy Smith (Not in Mondays), nhiroki, michaeln, shimazu+serviceworker_chromium.org, serviceworker-reviews, Aaron Boodman, kinuko+serviceworker, horo+watch_chromium.org, darin (slow to review), kouhei (in TOK)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use associated interface on DownloadedTempFile (patchset #10 id:180001 of https://codereview.chromium.org/2561743003/ ) Reason for revert: Culprit suspect for failing ThreadSanitizer tests, e.g. https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%20Tests/builds/581/steps/content_browsertests/logs/RenderThreadImplBrowserTest.InputHandlerManagerDestroyedAfterCompositorThread Original issue's description: > Use associated interface on DownloadedTempFile > > Blob systems depends on the ordering of loading IPC messages. That is, > the blob creation IPC via XHR is issued before the destruction of > DownloadedTempFile, and it expects to the blob IPC is handled before > DownloadedTempFile IPC. > However in the previous code, that is not guaranteed by Mojo, and that > makes Layout tests flaky. This CL switches DownLoadedTempFile in a loading > IPC to an associated interface to ensure it preserves the ordering of IPC > to other loading IPCs. > > BUG=670562 > > Review-Url: https://codereview.chromium.org/2561743003 > Cr-Commit-Position: refs/heads/master@{#445611} > Committed: https://chromium.googlesource.com/chromium/src/+/ad092abe5691a30391dbc0fd846af75e9917d37b TBR=yhirano@chromium.org,mmenke@chromium.org,dcheng@chromium.org,yzshen@chromium.org,kinuko@chromium.org,tzik@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=670562

Patch Set 1 #

Patch Set 2 : Resolved conflicts. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -78 lines) Patch
M content/browser/loader/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/downloaded_temp_file_impl.h View 1 2 chunks +2 lines, -17 lines 0 comments Download
M content/browser/loader/downloaded_temp_file_impl.cc View 1 chunk +2 lines, -19 lines 0 comments Download
M content/browser/loader/mojo_async_resource_handler.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/loader/mojo_async_resource_handler.cc View 1 5 chunks +6 lines, -17 lines 0 comments Download
M content/browser/loader/mojo_async_resource_handler_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/loader/test_url_loader_client.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/loader/test_url_loader_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_fetch_dispatcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/child/url_loader_client_impl.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M content/child/url_loader_client_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/url_loader.mojom View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
mastiz
Created Revert of Use associated interface on DownloadedTempFile
3 years, 11 months ago (2017-01-25 09:46:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658583002/1
3 years, 11 months ago (2017-01-25 09:46:43 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 09:48:22 UTC) #5
Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

Powered by Google App Engine
This is Rietveld 408576698