Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Side by Side Diff: content/browser/loader/mojo_async_resource_handler.cc

Issue 2658583002: Revert of Use associated interface on DownloadedTempFile (Closed)
Patch Set: Rebased. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/loader/mojo_async_resource_handler.h" 5 #include "content/browser/loader/mojo_async_resource_handler.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/bind.h"
12 #include "base/command_line.h" 11 #include "base/command_line.h"
13 #include "base/location.h" 12 #include "base/location.h"
14 #include "base/logging.h" 13 #include "base/logging.h"
15 #include "base/macros.h" 14 #include "base/macros.h"
16 #include "base/memory/ptr_util.h" 15 #include "base/memory/ptr_util.h"
17 #include "base/strings/string_number_conversions.h" 16 #include "base/strings/string_number_conversions.h"
18 #include "base/time/time.h" 17 #include "base/time/time.h"
19 #include "content/browser/loader/downloaded_temp_file_impl.h" 18 #include "content/browser/loader/downloaded_temp_file_impl.h"
20 #include "content/browser/loader/netlog_observer.h" 19 #include "content/browser/loader/netlog_observer.h"
21 #include "content/browser/loader/resource_controller.h" 20 #include "content/browser/loader/resource_controller.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 52
54 void InitializeResourceBufferConstants() { 53 void InitializeResourceBufferConstants() {
55 static bool did_init = false; 54 static bool did_init = false;
56 if (did_init) 55 if (did_init)
57 return; 56 return;
58 did_init = true; 57 did_init = true;
59 58
60 GetNumericArg("resource-buffer-size", &g_allocation_size); 59 GetNumericArg("resource-buffer-size", &g_allocation_size);
61 } 60 }
62 61
63 void NotReached(mojom::URLLoaderAssociatedRequest mojo_request,
64 mojom::URLLoaderClientAssociatedPtr url_loader_client) {
65 NOTREACHED();
66 }
67
68 } // namespace 62 } // namespace
69 63
70 // This class is for sharing the ownership of a ScopedDataPipeProducerHandle 64 // This class is for sharing the ownership of a ScopedDataPipeProducerHandle
71 // between WriterIOBuffer and MojoAsyncResourceHandler. 65 // between WriterIOBuffer and MojoAsyncResourceHandler.
72 class MojoAsyncResourceHandler::SharedWriter final 66 class MojoAsyncResourceHandler::SharedWriter final
73 : public base::RefCountedThreadSafe<SharedWriter> { 67 : public base::RefCountedThreadSafe<SharedWriter> {
74 public: 68 public:
75 explicit SharedWriter(mojo::ScopedDataPipeProducerHandle writer) 69 explicit SharedWriter(mojo::ScopedDataPipeProducerHandle writer)
76 : writer_(std::move(writer)) {} 70 : writer_(std::move(writer)) {}
77 mojo::DataPipeProducerHandle writer() { return writer_.get(); } 71 mojo::DataPipeProducerHandle writer() { return writer_.get(); }
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 // This member is for keeping the writer alive. 103 // This member is for keeping the writer alive.
110 scoped_refptr<SharedWriter> writer_; 104 scoped_refptr<SharedWriter> writer_;
111 105
112 DISALLOW_COPY_AND_ASSIGN(WriterIOBuffer); 106 DISALLOW_COPY_AND_ASSIGN(WriterIOBuffer);
113 }; 107 };
114 108
115 MojoAsyncResourceHandler::MojoAsyncResourceHandler( 109 MojoAsyncResourceHandler::MojoAsyncResourceHandler(
116 net::URLRequest* request, 110 net::URLRequest* request,
117 ResourceDispatcherHostImpl* rdh, 111 ResourceDispatcherHostImpl* rdh,
118 mojom::URLLoaderAssociatedRequest mojo_request, 112 mojom::URLLoaderAssociatedRequest mojo_request,
119 mojom::URLLoaderClientAssociatedPtr url_loader_client, 113 mojom::URLLoaderClientAssociatedPtr url_loader_client)
120 ResourceType resource_type)
121 : ResourceHandler(request), 114 : ResourceHandler(request),
122 rdh_(rdh), 115 rdh_(rdh),
123 binding_(this, std::move(mojo_request)), 116 binding_(this, std::move(mojo_request)),
124 url_loader_client_(std::move(url_loader_client)), 117 url_loader_client_(std::move(url_loader_client)),
125 weak_factory_(this) { 118 weak_factory_(this) {
126 DCHECK(url_loader_client_); 119 DCHECK(url_loader_client_);
127 InitializeResourceBufferConstants(); 120 InitializeResourceBufferConstants();
128 // This unretained pointer is safe, because |binding_| is owned by |this| and 121 // This unretained pointer is safe, because |binding_| is owned by |this| and
129 // the callback will never be called after |this| is destroyed. 122 // the callback will never be called after |this| is destroyed.
130 binding_.set_connection_error_handler( 123 binding_.set_connection_error_handler(
131 base::Bind(&MojoAsyncResourceHandler::Cancel, base::Unretained(this))); 124 base::Bind(&MojoAsyncResourceHandler::Cancel, base::Unretained(this)));
132 125
133 if (IsResourceTypeFrame(resource_type)) { 126 GetRequestInfo()->set_on_transfer(base::Bind(
134 GetRequestInfo()->set_on_transfer(base::Bind( 127 &MojoAsyncResourceHandler::OnTransfer, weak_factory_.GetWeakPtr()));
135 &MojoAsyncResourceHandler::OnTransfer, weak_factory_.GetWeakPtr()));
136 } else {
137 GetRequestInfo()->set_on_transfer(base::Bind(&NotReached));
138 }
139 } 128 }
140 129
141 MojoAsyncResourceHandler::~MojoAsyncResourceHandler() { 130 MojoAsyncResourceHandler::~MojoAsyncResourceHandler() {
142 if (has_checked_for_sufficient_resources_) 131 if (has_checked_for_sufficient_resources_)
143 rdh_->FinishedWithResourcesForRequest(request()); 132 rdh_->FinishedWithResourcesForRequest(request());
144 } 133 }
145 134
146 bool MojoAsyncResourceHandler::OnRequestRedirected( 135 bool MojoAsyncResourceHandler::OnRequestRedirected(
147 const net::RedirectInfo& redirect_info, 136 const net::RedirectInfo& redirect_info,
148 ResourceResponse* response, 137 ResourceResponse* response,
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 } 170 }
182 171
183 NetLogObserver::PopulateResponseInfo(request(), response); 172 NetLogObserver::PopulateResponseInfo(request(), response);
184 response->head.encoded_data_length = request()->raw_header_size(); 173 response->head.encoded_data_length = request()->raw_header_size();
185 reported_total_received_bytes_ = response->head.encoded_data_length; 174 reported_total_received_bytes_ = response->head.encoded_data_length;
186 175
187 response->head.request_start = request()->creation_time(); 176 response->head.request_start = request()->creation_time();
188 response->head.response_start = base::TimeTicks::Now(); 177 response->head.response_start = base::TimeTicks::Now();
189 sent_received_response_message_ = true; 178 sent_received_response_message_ = true;
190 179
191 mojom::DownloadedTempFileAssociatedPtrInfo downloaded_file_ptr; 180 mojom::DownloadedTempFilePtr downloaded_file_ptr;
192 if (!response->head.download_file_path.empty()) { 181 if (!response->head.download_file_path.empty()) {
193 downloaded_file_ptr = DownloadedTempFileImpl::Create( 182 downloaded_file_ptr = DownloadedTempFileImpl::Create(info->GetChildID(),
194 binding_.associated_group(), info->GetChildID(), info->GetRequestID()); 183 info->GetRequestID());
195 rdh_->RegisterDownloadedTempFile(info->GetChildID(), info->GetRequestID(), 184 rdh_->RegisterDownloadedTempFile(info->GetChildID(), info->GetRequestID(),
196 response->head.download_file_path); 185 response->head.download_file_path);
197 } 186 }
198 187
199 url_loader_client_->OnReceiveResponse(response->head, 188 url_loader_client_->OnReceiveResponse(response->head,
200 std::move(downloaded_file_ptr)); 189 std::move(downloaded_file_ptr));
201 190
202 net::IOBufferWithSize* metadata = GetResponseMetadata(request()); 191 net::IOBufferWithSize* metadata = GetResponseMetadata(request());
203 if (metadata) { 192 if (metadata) {
204 const uint8_t* data = reinterpret_cast<const uint8_t*>(metadata->data()); 193 const uint8_t* data = reinterpret_cast<const uint8_t*>(metadata->data());
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
544 base::Bind(&MojoAsyncResourceHandler::OnUploadProgressACK, 533 base::Bind(&MojoAsyncResourceHandler::OnUploadProgressACK,
545 weak_factory_.GetWeakPtr())); 534 weak_factory_.GetWeakPtr()));
546 } 535 }
547 536
548 void MojoAsyncResourceHandler::OnUploadProgressACK() { 537 void MojoAsyncResourceHandler::OnUploadProgressACK() {
549 if (upload_progress_tracker_) 538 if (upload_progress_tracker_)
550 upload_progress_tracker_->OnAckReceived(); 539 upload_progress_tracker_->OnAckReceived();
551 } 540 }
552 541
553 } // namespace content 542 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/loader/mojo_async_resource_handler.h ('k') | content/browser/loader/mojo_async_resource_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698