Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2658573006: Ensure message listeners invoke UrlManager on UI thread (Closed)

Created:
3 years, 10 months ago by mattreynolds
Modified:
3 years, 10 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure message listeners invoke UrlManager on UI thread To avoid concurrency issues, all calls to UrlManager must be made on the main thread. This CL touches the BackgroundMessageListener in PhysicalWebBleClient. BUG=683923 Review-Url: https://codereview.chromium.org/2658573006 Cr-Commit-Position: refs/heads/master@{#447066} Committed: https://chromium.googlesource.com/chromium/src/+/9bbc684353acc634cb47b87bc945d0e5158841f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java View 2 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mattreynolds
Hi David, PTAL
3 years, 10 months ago (2017-01-27 00:40:29 UTC) #2
cco3
lgtm
3 years, 10 months ago (2017-01-27 17:31:50 UTC) #5
David Trainor- moved to gerrit
lgtm
3 years, 10 months ago (2017-01-30 18:19:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658573006/1
3 years, 10 months ago (2017-01-30 20:05:27 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 21:19:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9bbc684353acc634cb47b87bc945...

Powered by Google App Engine
This is Rietveld 408576698