Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 2658573003: Use explicit WebString conversions in clipboard and drag-and-drop code (Closed)

Created:
3 years, 11 months ago by kinuko
Modified:
3 years, 11 months ago
Reviewers:
dcheng
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use explicit WebString conversions in clipboard and drag-and-drop code As we're deprecating implicit conversions for WebString <-> string16 replace them with explicit methods. (See crbug.com/667131 for more details) BUG=667131 R=dcheng@chromium.org Review-Url: https://codereview.chromium.org/2658573003 Cr-Commit-Position: refs/heads/master@{#446217} Committed: https://chromium.googlesource.com/chromium/src/+/365b58f79079581b244a12f4bf5aaa6c0c54b305

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -20 lines) Patch
M content/renderer/clipboard_utils.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/renderer/drop_data_builder.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M content/renderer/webclipboard_impl.cc View 5 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
kinuko
Daniel, can you review?
3 years, 11 months ago (2017-01-25 13:33:17 UTC) #2
dcheng
LGTM
3 years, 11 months ago (2017-01-26 01:59:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658573003/1
3 years, 11 months ago (2017-01-26 03:10:49 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 03:16:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/365b58f79079581b244a12f4bf5a...

Powered by Google App Engine
This is Rietveld 408576698