[Offline Pages] Adding a network check in test scheduler.

[Offline Pages] Adding a network check in test scheduler.

The test scheduler wasn't behaving as GCMNetworkManager since it had no
idea if the network is gone at the moment it was called back from request
coodinator. Adding a check which would prevent the test scheduler from
calling startImmediateProcessing when there's no network.

BUG=682766
Review-Url: https://codereview.chromium.org/2658513004
Cr-Commit-Position: refs/heads/master@{#445922}
Committed: https://chromium.googlesource.com/chromium/src/+/76d8b4dc116f6e4e2c59b4d0b79fb82dacd4f6a9

[romax, 2017-01-25 01:51:41]

romax@chromium.org changed reviewers:
+ petewil@chromium.org

[romax, 2017-01-25 01:51:41]

PTAL, thanks!

[Pete Williamson, 2017-01-25 02:01:42]

lgtm with nits

https://codereview.chromium.org/2658513004/diff/1/chrome/browser/android/offl...
File
chrome/browser/android/offline_pages/evaluation/evaluation_test_scheduler.cc
(right):

https://codereview.chromium.org/2658513004/diff/1/chrome/browser/android/offl...
chrome/browser/android/offline_pages/evaluation/evaluation_test_scheduler.cc:82:
// This method is not expected to be called in test harnees. Adding a log in
nit; harnees -> harness
Same comment for Unschedule()

[romax, 2017-01-25 02:19:21]

The CQ bit was checked by romax@chromium.org

[romax, 2017-01-25 02:19:22]

The patchset sent to the CQ was uploaded after l-g-t-m from petewil@chromium.org
Link to the patchset: https://codereview.chromium.org/2658513004/#ps20001
(title: "comments.")

[commit-bot: I haz the power, 2017-01-25 02:19:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 03:00:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485310761570110,
"parent_rev": "4fad6cb6f585cdfeaccf613a9c310f04260c87c3", "commit_rev":
"76d8b4dc116f6e4e2c59b4d0b79fb82dacd4f6a9"}

[commit-bot: I haz the power, 2017-01-25 03:01:32]

Description was changed from

==========
[Offline Pages] Adding a network check in test scheduler.

The test scheduler wasn't behaving as GCMNetworkManager since it had no
idea if the network is gone at the moment it was called back from request
coodinator. Adding a check which would prevent the test scheduler from
calling startImmediateProcessing when there's no network.

BUG=682766
==========

to

==========
[Offline Pages] Adding a network check in test scheduler.

The test scheduler wasn't behaving as GCMNetworkManager since it had no
idea if the network is gone at the moment it was called back from request
coodinator. Adding a check which would prevent the test scheduler from
calling startImmediateProcessing when there's no network.

BUG=682766

Review-Url: https://codereview.chromium.org/2658513004
Cr-Commit-Position: refs/heads/master@{#445922}
Committed:
https://chromium.googlesource.com/chromium/src/+/76d8b4dc116f6e4e2c59b4d0b79f...
==========

[commit-bot: I haz the power, 2017-01-25 03:01:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/76d8b4dc116f6e4e2c59b4d0b79f...