[Cleanup] Rename Hidden to Background in WMPI.

media/blink/webmediaplayer_impl.h

Index: media/blink/webmediaplayer_impl.h
diff --git a/media/blink/webmediaplayer_impl.h b/media/blink/webmediaplayer_impl.h
index 0942929e41b86d6a6792022928d4d7d14af1323c..f34c9f83125efe085add86726d62619915273587 100644
--- a/media/blink/webmediaplayer_impl.h
+++ b/media/blink/webmediaplayer_impl.h
@@ -329,7 +329,7 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
   // are:
   //   - isRemote(),
   //   - hasVideo(),
-  //   - delegate_->IsHidden(),
+  //   - delegate_->IsBackground(),

[sandersd (OOO until July 31), 2017/01/24 23:35:48]

This didn't get changed in this CL.

[whywhat, 2017/01/24 23:50:54]

Should be delegate_->IsFrameHidden() though, updated.
Or should we rather put IsBackgrounded() there?

[sandersd (OOO until July 31), 2017/01/24 23:55:25]

If you don't do that now, I'll give it a try next time I touch the delegate. I
think I've become convinced that it's better than the current methods.

   //   - network_state_, ready_state_,
   //   - is_idle_, must_suspend_,
   //   - paused_, ended_,
@@ -368,7 +368,7 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
   void CreateWatchTimeReporter();
 
   // Returns true if the player is hidden.
-  bool IsHidden() const;
+  bool IsBackground() const;

[sandersd (OOO until July 31), 2017/01/24 23:35:48]

Nit: I prefer IsBackgrounded(), grammatically.

[whywhat, 2017/01/24 23:50:54]

Right, I was wondering about that :) Done.

 
   // Returns true if the player's source is streaming.
   bool IsStreaming() const;
@@ -381,13 +381,13 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
   // meaning only after the pipeline has started, otherwise returns false.
   // Doesn't check if the video can actually be paused depending on the
   // pipeline's state.
-  bool ShouldPauseVideoWhenHidden() const;
+  bool ShouldPauseVideoWhenBackground() const;
 
   // Whether the video track should be disabled when hidden. Uses metadata so
   // has meaning only after the pipeline has started, otherwise returns false.
   // Doesn't check if the video track can actually be disabled depending on the
   // pipeline's state.
-  bool ShouldDisableVideoWhenHidden() const;
+  bool ShouldDisableVideoWhenBackground() const;
 
   // Whether the video is suitable for background playback optimizations (either
   // pausing it or disabling the video track). Uses metadata so has meaning only