[Cleanup] Rename Hidden to Background in WMPI.

media/blink/webmediaplayer_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_
 #define MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 311 matching lines @@
 
   // Inspects the current playback state and:
   //   - notifies |delegate_|,
   //   - toggles the memory usage reporting timer, and
   //   - toggles suspend/resume as necessary.
   //
   // This method should be called any time its dependent values change. These
   // are:
   //   - isRemote(),
   //   - hasVideo(),
-  //   - delegate_->IsHidden(),
+  //   - delegate_->IsBackground(),

[sandersd (OOO until July 31), 2017/01/24 23:35:48]

This didn't get changed in this CL.

[whywhat, 2017/01/24 23:50:54]

Should be delegate_->IsFrameHidden() though, updated.
Or should we rather put IsBackgrounded() there?

[sandersd (OOO until July 31), 2017/01/24 23:55:25]

If you don't do that now, I'll give it a try next time I touch the delegate. I
think I've become convinced that it's better than the current methods.

   //   - network_state_, ready_state_,
   //   - is_idle_, must_suspend_,
   //   - paused_, ended_,
   //   - pending_suspend_resume_cycle_,
   void UpdatePlayState();
 
   // Methods internal to UpdatePlayState().
   PlayState UpdatePlayState_ComputePlayState(bool is_remote,
                                              bool is_streaming,
                                              bool is_suspended,
@@ skipping 18 matching lines @@
   // since then.
   //
   // This is used to delay suspension long enough for preroll to complete, which
   // is necessay because play() will not be called before HaveFutureData (and
   // thus we think we are idle forever).
   bool IsPrerollAttemptNeeded();
 
   void CreateWatchTimeReporter();
 
   // Returns true if the player is hidden.
-  bool IsHidden() const;
+  bool IsBackground() const;

[sandersd (OOO until July 31), 2017/01/24 23:35:48]

Nit: I prefer IsBackgrounded(), grammatically.

[whywhat, 2017/01/24 23:50:54]

Right, I was wondering about that :) Done.

 
   // Returns true if the player's source is streaming.
   bool IsStreaming() const;
 
   // Return whether |pipeline_metadata_| is compatible with an overlay. This
   // is intended for android.
   bool DoesOverlaySupportMetadata() const;
 
   // Whether the video should be paused when hidden. Uses metadata so has
   // meaning only after the pipeline has started, otherwise returns false.
   // Doesn't check if the video can actually be paused depending on the
   // pipeline's state.
-  bool ShouldPauseVideoWhenHidden() const;
+  bool ShouldPauseVideoWhenBackground() const;
 
   // Whether the video track should be disabled when hidden. Uses metadata so
   // has meaning only after the pipeline has started, otherwise returns false.
   // Doesn't check if the video track can actually be disabled depending on the
   // pipeline's state.
-  bool ShouldDisableVideoWhenHidden() const;
+  bool ShouldDisableVideoWhenBackground() const;
 
   // Whether the video is suitable for background playback optimizations (either
   // pausing it or disabling the video track). Uses metadata so has meaning only
   // after the pipeline has started, otherwise returns false.
   // The logical OR between the two methods above that is also used as their
   // common implementation.
   bool IsBackgroundOptimizationCandidate() const;
 
   // If enabling or disabling background video optimization has been delayed,
   // because of the pipeline not running, seeking or resuming, this method
@@ skipping 285 matching lines @@
 
   // Pipeline media duration overridden by tests.
   base::Optional<base::TimeDelta> pipeline_media_duration_for_test_;
 
   DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_