[Cleanup] Rename Hidden to Background in WMPI.

[Cleanup] Rename Hidden to Background in WMPI.

Agreed to the rename in https://codereview.chromium.org/2653553005/

BUG=None
TEST=Run media_blink_unittests

[whywhat, 2017-01-24 23:16:49]

avayvod@chromium.org changed reviewers:
+ sandersd@chromium.org, watk@chromium.org

[whywhat, 2017-01-24 23:16:49]

PTAL

I'd hesitate submitting this soon as merging M57 fixes to background
optimizations might become tricky (unless this rename is merged too).

[sandersd (OOO until July 31), 2017-01-24 23:35:48]

lgtm

https://codereview.chromium.org/2658513003/diff/1/media/blink/webmediaplayer_...
File media/blink/webmediaplayer_impl.h (right):

https://codereview.chromium.org/2658513003/diff/1/media/blink/webmediaplayer_...
media/blink/webmediaplayer_impl.h:332: //   - delegate_->IsBackground(),
This didn't get changed in this CL.

https://codereview.chromium.org/2658513003/diff/1/media/blink/webmediaplayer_...
media/blink/webmediaplayer_impl.h:371: bool IsBackground() const;
Nit: I prefer IsBackgrounded(), grammatically.

[whywhat, 2017-01-24 23:48:14]

More renames in the comments etc

[whywhat, 2017-01-24 23:50:54]

https://codereview.chromium.org/2658513003/diff/1/media/blink/webmediaplayer_...
File media/blink/webmediaplayer_impl.h (right):

https://codereview.chromium.org/2658513003/diff/1/media/blink/webmediaplayer_...
media/blink/webmediaplayer_impl.h:332: //   - delegate_->IsBackground(),
On 2017/01/24 at 23:35:48, sandersd wrote:
> This didn't get changed in this CL.

Should be delegate_->IsFrameHidden() though, updated.
Or should we rather put IsBackgrounded() there?

https://codereview.chromium.org/2658513003/diff/1/media/blink/webmediaplayer_...
media/blink/webmediaplayer_impl.h:371: bool IsBackground() const;
On 2017/01/24 at 23:35:48, sandersd wrote:
> Nit: I prefer IsBackgrounded(), grammatically.

Right, I was wondering about that :) Done.

[sandersd (OOO until July 31), 2017-01-24 23:55:25]

https://codereview.chromium.org/2658513003/diff/1/media/blink/webmediaplayer_...
File media/blink/webmediaplayer_impl.h (right):

https://codereview.chromium.org/2658513003/diff/1/media/blink/webmediaplayer_...
media/blink/webmediaplayer_impl.h:332: //   - delegate_->IsBackground(),
On 2017/01/24 23:50:54, whywhat_slow_PST_till_Feb_6 wrote:
> On 2017/01/24 at 23:35:48, sandersd wrote:
> > This didn't get changed in this CL.
> 
> Should be delegate_->IsFrameHidden() though, updated.
> Or should we rather put IsBackgrounded() there?

If you don't do that now, I'll give it a try next time I touch the delegate. I
think I've become convinced that it's better than the current methods.

[whywhat, 2017-01-25 01:57:01]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[whywhat, 2017-01-25 01:57:32]

On 2017/01/24 at 23:55:25, sandersd wrote:
>
https://codereview.chromium.org/2658513003/diff/1/media/blink/webmediaplayer_...
> File media/blink/webmediaplayer_impl.h (right):
> 
>
https://codereview.chromium.org/2658513003/diff/1/media/blink/webmediaplayer_...
> media/blink/webmediaplayer_impl.h:332: //   - delegate_->IsBackground(),
> On 2017/01/24 23:50:54, whywhat_slow_PST_till_Feb_6 wrote:
> > On 2017/01/24 at 23:35:48, sandersd wrote:
> > > This didn't get changed in this CL.
> > 
> > Should be delegate_->IsFrameHidden() though, updated.
> > Or should we rather put IsBackgrounded() there?
> 
> If you don't do that now, I'll give it a try next time I touch the delegate. I
think I've become convinced that it's better than the current methods.

Perhaps, let's submit this CL right before you start on the next refactoring?

[commit-bot: I haz the power, 2017-01-25 01:57:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 03:25:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 03:25:42]

Dry run: This issue passed the CQ dry run.

[sandersd (OOO until July 31), 2017-01-25 19:02:16]

On 2017/01/25 01:57:32, whywhat_slow_PST_till_Feb_6 wrote:
> On 2017/01/24 at 23:55:25, sandersd wrote:
> >
>
https://codereview.chromium.org/2658513003/diff/1/media/blink/webmediaplayer_...
> > File media/blink/webmediaplayer_impl.h (right):
> > 
> >
>
https://codereview.chromium.org/2658513003/diff/1/media/blink/webmediaplayer_...
> > media/blink/webmediaplayer_impl.h:332: //   - delegate_->IsBackground(),
> > On 2017/01/24 23:50:54, whywhat_slow_PST_till_Feb_6 wrote:
> > > On 2017/01/24 at 23:35:48, sandersd wrote:
> > > > This didn't get changed in this CL.
> > > 
> > > Should be delegate_->IsFrameHidden() though, updated.
> > > Or should we rather put IsBackgrounded() there?
> > 
> > If you don't do that now, I'll give it a try next time I touch the delegate.
I
> think I've become convinced that it's better than the current methods.
> 
> Perhaps, let's submit this CL right before you start on the next refactoring?

SGTM.

[watk, 2017-07-06 20:42:04]

Description was changed from

==========
[Cleanup] Rename Hidden to Background in WMPI.

Agreed to the rename in https://codereview.chromium.org/2653553005/

BUG=None
TEST=Run media_blink_unittests
==========

to

==========
[Cleanup] Rename Hidden to Background in WMPI.

Agreed to the rename in https://codereview.chromium.org/2653553005/

BUG=None
TEST=Run media_blink_unittests
==========

[watk, 2017-07-06 20:42:04]

watk@chromium.org changed reviewers:
- watk@chromium.org