Dev Tools: Adjust Dev Tool Source panel show/hide sidebar icons

Dev Tools: Adjust Dev Tool Source panel show/hide sidebar icons

Instead of rotating icons for the right hand side, flip the icons along the x-axis.

BUG=671930
R=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2658363003
Cr-Commit-Position: refs/heads/master@{#446978}
Committed: https://chromium.googlesource.com/chromium/src/+/711b0a82a640608bf4e069b9398ec415e2b8b20a

[Jake Hendy, 2017-01-28 16:45:03]

Description was changed from

==========
Adjust Dev Tool Source panel show/hide sidebar icons

Instead of rotating icons, flip them along the x-axis.

Add Jake Hendy to root AUTHORS
http://imgur.com/a/FHN3q has some lines drawn to show alignment
BUG=671930
R=lushnikov@chromium.org
==========

to

==========
Adjust Dev Tool Source panel show/hide sidebar icons

Instead of rotating icons for the right hand side, flip the icons along the
x-axis.

http://imgur.com/a/FHN3q has some lines drawn to show alignment

BUG=671930
R=lushnikov@chromium.org
==========

[lushnikov, 2017-01-30 00:53:00]

lgtm, thank you!

[lushnikov, 2017-01-30 00:58:24]

A few nits before landing this:

1. Please, prefix the CL title with the "DevTools:" tag? (e.g. like in
crrev.com/2654043004) You'll need to do it in two places: both in issue title
and in the first line of issue description
2. Please, move the screenshot URL out of CL description. It's better to either
attach screenshots to CLs or post them as CL messages.

Also, your CL is not publicly visible until you hit "publish" for the first
time. We usually send a "please, take a look message" to publish it.

[Jake Hendy, 2017-01-30 11:02:49]

Description was changed from

==========
Adjust Dev Tool Source panel show/hide sidebar icons

Instead of rotating icons for the right hand side, flip the icons along the
x-axis.

http://imgur.com/a/FHN3q has some lines drawn to show alignment

BUG=671930
R=lushnikov@chromium.org
==========

to

==========
Dev Tools: Adjust Dev Tool Source panel show/hide sidebar icons

Instead of rotating icons for the right hand side, flip the icons along the
x-axis.

http://imgur.com/a/FHN3q has some lines drawn to show alignment

BUG=671930
R=lushnikov@chromium.org
==========

[Jake Hendy, 2017-01-30 11:03:00]

Description was changed from

==========
Dev Tools: Adjust Dev Tool Source panel show/hide sidebar icons

Instead of rotating icons for the right hand side, flip the icons along the
x-axis.

http://imgur.com/a/FHN3q has some lines drawn to show alignment

BUG=671930
R=lushnikov@chromium.org
==========

to

==========
Dev Tools: Adjust Dev Tool Source panel show/hide sidebar icons

Instead of rotating icons for the right hand side, flip the icons along the
x-axis.

BUG=671930
R=lushnikov@chromium.org
==========

[Jake Hendy, 2017-01-30 11:04:49]

Here's a screenshot with red lines drawn in to show alignment of the icons:

http://imgur.com/a/FHN3q

[Jake Hendy, 2017-01-30 11:07:18]

On 2017/01/30 00:58:24, lushnikov wrote:
> A few nits before landing this:
> 
> 1. Please, prefix the CL title with the "DevTools:" tag? (e.g. like in
> crrev.com/2654043004) You'll need to do it in two places: both in issue title
> and in the first line of issue description
> 2. Please, move the screenshot URL out of CL description. It's better to
either
> attach screenshots to CLs or post them as CL messages.
> 
> Also, your CL is not publicly visible until you hit "publish" for the first
> time. We usually send a "please, take a look message" to publish it.

Thank you for the advice!

I've updated the issue and added a CL message with the screenshot as I couldn't
find a way to add it as an attachment.

[lushnikov, 2017-01-30 12:42:24]

Thanks Jake! 

On 2017/01/30 11:07:18, Jake Hendy wrote:
> On 2017/01/30 00:58:24, lushnikov wrote:
> > A few nits before landing this:
> > 
> > 1. Please, prefix the CL title with the "DevTools:" tag? (e.g. like in
> > crrev.com/2654043004) You'll need to do it in two places: both in issue
title
> > and in the first line of issue description
> > 2. Please, move the screenshot URL out of CL description. It's better to
> either
> > attach screenshots to CLs or post them as CL messages.
> > 
> > Also, your CL is not publicly visible until you hit "publish" for the first
> > time. We usually send a "please, take a look message" to publish it.
> 
> Thank you for the advice!
> 
> I've updated the issue and added a CL message with the screenshot as I
couldn't
> find a way to add it as an attachment.

Oops, I actually meant "attaching to a crbug"

[lushnikov, 2017-01-30 12:42:31]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-01-30 12:42:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 14:21:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485780151107570, "parent_rev":
"8a440b84693ff261a07858d64655f90c285359fb", "commit_rev":
"711b0a82a640608bf4e069b9398ec415e2b8b20a"}

[commit-bot: I haz the power, 2017-01-30 14:22:20]

Description was changed from

==========
Dev Tools: Adjust Dev Tool Source panel show/hide sidebar icons

Instead of rotating icons for the right hand side, flip the icons along the
x-axis.

BUG=671930
R=lushnikov@chromium.org
==========

to

==========
Dev Tools: Adjust Dev Tool Source panel show/hide sidebar icons

Instead of rotating icons for the right hand side, flip the icons along the
x-axis.

BUG=671930
R=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2658363003
Cr-Commit-Position: refs/heads/master@{#446978}
Committed:
https://chromium.googlesource.com/chromium/src/+/711b0a82a640608bf4e069b9398e...
==========

[commit-bot: I haz the power, 2017-01-30 14:22:23]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/711b0a82a640608bf4e069b9398e...