Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2658313002: Only flush not yet started and finished compile jobs from gc (Closed)

Created:
3 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 10 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Only flush not yet started and finished compile jobs from gc We shouldn't block during GC for arbitrarily long intervals. BUG=chromium:686153, chromium:642532 R=verwaest@chromium.org,hpayer@chromium.org Review-Url: https://codereview.chromium.org/2658313002 Cr-Commit-Position: refs/heads/master@{#42761} Committed: https://chromium.googlesource.com/v8/v8/+/22858cb0d494c936cd85c1d1f0cebfc70e72fe08

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -6 lines) Patch
M src/compiler-dispatcher/optimizing-compile-dispatcher.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/compiler-dispatcher/optimizing-compile-dispatcher.cc View 1 chunk +17 lines, -1 line 0 comments Download
M src/debug/debug.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/heap.cc View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
jochen (gone - plz use gerrit)
3 years, 10 months ago (2017-01-27 22:33:50 UTC) #1
jochen (gone - plz use gerrit)
adding more reviewers
3 years, 10 months ago (2017-01-28 01:05:14 UTC) #7
Toon Verwaest
lgtm
3 years, 10 months ago (2017-01-30 01:53:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658313002/1
3 years, 10 months ago (2017-01-30 01:54:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/22858cb0d494c936cd85c1d1f0cebfc70e72fe08
3 years, 10 months ago (2017-01-30 02:27:24 UTC) #13
Mircea Trofin
3 years, 10 months ago (2017-01-30 02:31:47 UTC) #14
Message was sent while issue was closed.
On 2017/01/30 02:27:24, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/v8/v8/+/22858cb0d494c936cd85c1d1f0cebfc70e7...

(Apologies for the drive-by) is it possible to regression test this?

Powered by Google App Engine
This is Rietveld 408576698