Chromium Code Reviews

Issue 2658253002: [csa] Add IsIntPtrOrSmiConstantZero to detect and optimize constant zero values (Closed)

Created:
3 years, 10 months ago by danno
Modified:
3 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[csa] Add IsIntPtrOrSmiConstantZero to detect and optimize constant zero values Review-Url: https://codereview.chromium.org/2658253002 Cr-Commit-Position: refs/heads/master@{#42766} Committed: https://chromium.googlesource.com/v8/v8/+/753a2b55781face0f10b8d9a6fb0da45ede2c693

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+13 lines, -2 lines)
M src/code-stub-assembler.h View 1 chunk +2 lines, -0 lines 0 comments
M src/code-stub-assembler.cc View 2 chunks +11 lines, -2 lines 0 comments

Messages

Total messages: 12 (8 generated)
danno
ptal
3 years, 10 months ago (2017-01-27 16:06:41 UTC) #4
Igor Sheludko
lgtm
3 years, 10 months ago (2017-01-27 16:48:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658253002/1
3 years, 10 months ago (2017-01-30 10:25:52 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 10:57:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/753a2b55781face0f10b8d9a6fb0da45ede...

Powered by Google App Engine