[foozzie] Make Error immutable to prevent changes to stack-trace api

[foozzie] Make Error immutable to prevent changes to stack-trace api

BUG=chromium:685633
NOTRY=true
TBR=yangguo@chromium.org, jarin@chromium.org

Review-Url: https://codereview.chromium.org/2658223002
Cr-Commit-Position: refs/heads/master@{#42726}
Committed: https://chromium.googlesource.com/v8/v8/+/9be4934d6f5a36135623472f4d72fae370452708

[Michael Achenbach, 2017-01-27 08:32:01]

Description was changed from

==========
[foozzie] Make Error immutable to prevent changes to stack-trace api

BUG=
==========

to

==========
[foozzie] Make Error immutable to prevent changes to stack-trace api

BUG=chromium:685633
NOTRY=true
TBR=yangguo@chromium.org, jarin@chromium.org
==========

[Michael Achenbach, 2017-01-27 08:32:02]

machenbach@chromium.org changed reviewers:
+ jarin@chromium.org, yangguo@chromium.org

[Michael Achenbach, 2017-01-27 08:33:24]

TBR. Was just a matter of time. The linked bug is a test case that overwrites
Error.prepareStackTrace and then accesses the column numbers of the stack
frames.

[Michael Achenbach, 2017-01-27 08:33:47]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2017-01-27 08:33:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 08:35:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485506027052810, "parent_rev":
"3f47c63ded839194989ba69c3039ea073636ef30", "commit_rev":
"9be4934d6f5a36135623472f4d72fae370452708"}

[commit-bot: I haz the power, 2017-01-27 08:35:40]

Description was changed from

==========
[foozzie] Make Error immutable to prevent changes to stack-trace api

BUG=chromium:685633
NOTRY=true
TBR=yangguo@chromium.org, jarin@chromium.org
==========

to

==========
[foozzie] Make Error immutable to prevent changes to stack-trace api

BUG=chromium:685633
NOTRY=true
TBR=yangguo@chromium.org, jarin@chromium.org

Review-Url: https://codereview.chromium.org/2658223002
Cr-Commit-Position: refs/heads/master@{#42726}
Committed:
https://chromium.googlesource.com/v8/v8/+/9be4934d6f5a36135623472f4d72fae3704...
==========

[commit-bot: I haz the power, 2017-01-27 08:35:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/9be4934d6f5a36135623472f4d72fae3704...

[Yang, 2017-01-27 08:35:48]

https://codereview.chromium.org/2658223002/diff/1/tools/foozzie/v8_mock.js
File tools/foozzie/v8_mock.js (right):

https://codereview.chromium.org/2658223002/diff/1/tools/foozzie/v8_mock.js#ne...
tools/foozzie/v8_mock.js:58: Object.freeze(Error)
I think using Object.defineProperty to make prepareStackTrace non-writable and
non-configurable should suffice.

[Michael Achenbach, 2017-01-27 08:41:59]

On 2017/01/27 08:35:48, Yang wrote:
> https://codereview.chromium.org/2658223002/diff/1/tools/foozzie/v8_mock.js
> File tools/foozzie/v8_mock.js (right):
> 
>
https://codereview.chromium.org/2658223002/diff/1/tools/foozzie/v8_mock.js#ne...
> tools/foozzie/v8_mock.js:58: Object.freeze(Error)
> I think using Object.defineProperty to make prepareStackTrace non-writable and
> non-configurable should suffice.

Follow up fix: https://codereview.chromium.org/2654273004/