Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2658203002: Convert DriveWebContentsManager to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
achuithb
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert DriveWebContentsManager to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2658203002 Cr-Commit-Position: refs/heads/master@{#446778} Committed: https://chromium.googlesource.com/chromium/src/+/984f50b22fe3337804670907f0cb51ae6539b17f

Patch Set 1 #

Patch Set 2 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M chrome/browser/chromeos/first_run/drive_first_run_controller.cc View 1 3 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
jam
3 years, 10 months ago (2017-01-27 15:59:33 UTC) #9
achuithb
lgtm
3 years, 10 months ago (2017-01-27 20:25:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658203002/20001
3 years, 10 months ago (2017-01-27 21:21:08 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 21:28:03 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/984f50b22fe3337804670907f0cb...

Powered by Google App Engine
This is Rietveld 408576698