Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Issue 2658173004: Merged: Squashed multiple commits. (Closed)

Created:
3 years, 10 months ago by bradnelson
Modified:
3 years, 10 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.7
Project:
v8
Visibility:
Public.

Description

Merged: Squashed multiple commits. Merged: [wasm] Errors in names section do not fail the whole module. Revision: a920c0d92bd5d1c59a23ba4c103c96d7724d0460 https://chromium.googlesource.com/v8/v8/+/a920c0d92bd5d1c59a23ba4c103c96d7724d0460 Merged: [wasm] Fix check failure on invalid name section Revision: 0ec3a264bcba5c899f7e72fa5b98dd191477e272 https://chromium.googlesource.com/v8/v8.git/+/0ec3a264bcba5c899f7e72fa5b98dd191477e272 BUG=chromium:684858, v8:5882 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2658173004 . Cr-Commit-Position: refs/branch-heads/5.7@{#57} Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} Committed: https://chromium.googlesource.com/v8/v8/+/a7e6ad9c3c577e6d111cb5897eaa357d51de0452

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -21 lines) Patch
M src/wasm/decoder.h View 2 chunks +13 lines, -2 lines 0 comments Download
M src/wasm/module-decoder.cc View 2 chunks +25 lines, -19 lines 0 comments Download
A test/mjsunit/regress/wasm/regression-684858.js View 1 chunk +34 lines, -0 lines 0 comments Download
A test/mjsunit/wasm/names.js View 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
bradnelson
3 years, 10 months ago (2017-01-27 22:28:55 UTC) #1
bradnelson
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 10 months ago (2017-01-27 22:28:56 UTC) #2
titzer
On 2017/01/27 22:28:56, bradnelson wrote: > NOTE: This script will no longer automatically update include/v8-version.h ...
3 years, 10 months ago (2017-01-27 22:32:46 UTC) #3
bradnelson
3 years, 10 months ago (2017-01-27 22:34:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a7e6ad9c3c577e6d111cb5897eaa357d51de0452.

Powered by Google App Engine
This is Rietveld 408576698